Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong title if no rename #77

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Wrong title if no rename #77

merged 1 commit into from
Oct 5, 2017

Conversation

leetal
Copy link

@leetal leetal commented Oct 5, 2017

So it seems i made a booboo... I did not understand the API to its fullest and thus this little (but serious) error sneaked in.

Fixes:

  • Fixes an issue where manual entries would not get their titles correct (would be empty strings) in the cases where no renames would be given. This commit also fixes some issues where updated license information would not update if changed.

…t (would be empty strings) in the cases where no renames would be given. This commit also fixes some issues where updated license information would not update if changed.
@leetal
Copy link
Author

leetal commented Oct 5, 2017

A workaround right now is to specify the same names in the "rename" section as the manual entries names.

@mono0926 mono0926 merged commit 4792478 into mono0926:master Oct 5, 2017
@mono0926
Copy link
Owner

mono0926 commented Oct 5, 2017

@leetal

I overlooked that, thanks 👍
I've released: https://github.com/mono0926/LicensePlist/releases/tag/1.7.1

@leetal
Copy link
Author

leetal commented Oct 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants