Improve Naming for Swift Packages using Package.resolved v2 #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem (Issue #179)
Attempted Solution
Based on the idea of @ykws:
This PR has a solution that works in most cases by doing exactly that and falls back to a sensible default name when parsing the
Package.swift
fails.In depth
What I implement here is a 3-step process to get the best name possible from the new version of Package.resolved:
Package.resolved
v1 file and instantly return the name from that otherwise (current v1 implementation)Package.swift
from the Repository by looking for the firstPackage
object, removing all nested code inside[...]
to eliminate dependency and target names and finally getting the remaining value forname
. If anything fails we returnnil
which lets us fall back to the result of Step 2.Edge cases I encountered are also added as Unit Tests, so you can play around in the parser with confidence.