Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --version option #173

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Support --version option #173

merged 1 commit into from
Jan 31, 2022

Conversation

hugehoge
Copy link
Contributor

Close #172

Swift Argument Parser has a built-in support for the --version option.

I used this feature in my implementation.

Confirmation

$ make build
$ .build/release/license-plist --version
3.16.0

@hugehoge
Support --version option
f8b82c9 
Implement using a feature that Swift Argument Parser provided.
hugehoge
hugehoge commented Jan 30, 2022
View reviewed changes
Sources/LicensePlist/main.swift
@@ -18,6 +18,8 @@ extension CompletionKind {

// Typename used for usage in help command
struct LicensePlist: ParsableCommand {
static let configuration = CommandConfiguration(version: Consts.version)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no side effects.

https://github.com/apple/swift-argument-parser/blob/d2930e8fcf9c33162b9fcc1d522bc975e2d4179b/Sources/ArgumentParser/Parsable%20Types/ParsableCommand.swift#L34-L42

https://github.com/apple/swift-argument-parser/blob/d2930e8fcf9c33162b9fcc1d522bc975e2d4179b/Sources/ArgumentParser/Parsable%20Types/CommandConfiguration.swift#L50-L89

@mono0926 mono0926 merged commit dc2b923 into mono0926:main Jan 31, 2022
@mono0926
Copy link
Owner

@hugehoge

Thanks, it has been released 👍
https://github.com/mono0926/LicensePlist/releases/tag/3.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --version option
2 participants
@hugehoge @mono0926