Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --xcworkspace-path option and "file parser" #166

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Conversation

orj
Copy link
Contributor

@orj orj commented Oct 7, 2021

Prior to this change you could not specify to look in a specific .xcworkspace folder for the Package.resolved file.

This change introduces a new command line option (that takes precendence over --xcodeproj-path) to direct LicensePlist to look in a specific workspace for the Package.resolved file.

Resolves #165

Happy to alter this PR if it doesn't fit in. Let me know how I can improve it.

Prior to this change you could not specify to look in a specific
.xcworkspace folder for the Package.resolved file.

This change introduces a new command line option (that takes
precendence over --xcodeproj-path) to direct LicensePlist to
look in a specific workspace for the Package.resolved file.
@orj orj changed the title Adds --xcworkspace-path option and "file parser". Adds --xcworkspace-path option and "file parser" Oct 7, 2021
As per project settings and to be more consistent with other
files,
@mono0926 mono0926 self-requested a review October 11, 2021 06:16
Copy link
Owner

@mono0926 mono0926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orj

Thanks for the pull request 🙏

Could you add --xcworkspace-path option to https://github.com/mono0926/LicensePlist/blob/main/README.md#options ?

@orj
Copy link
Contributor Author

orj commented Nov 24, 2021

@mono0926 I've updated the README as requested. Sorry this took a while (kinda forgot about it).

@mono0926 mono0926 merged commit a7b6936 into mono0926:main Nov 24, 2021
@mono0926
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package.resolved not found when using Xcode workspaces.
2 participants