This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
[release-8.4] [Debugger] Fix InvalidCastException in MacObjectValueTreeView.OnCopy() #9585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on "Find References" on GetRawValue(), it seems that this can sometimes return RawValueString instead of string. Make sure that we handle this instead of assuming the value returned by GetRawValue() is always a string. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1054038/
mrward
approved these changes
Jan 22, 2020
jstedfast
approved these changes
Jan 22, 2020
ketttY
approved these changes
Jan 22, 2020
slluis
approved these changes
Jan 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on "Find References" on GetRawValue(), it seems that this can
sometimes return RawValueString instead of string. Make sure that
we handle this instead of assuming the value returned by GetRawValue()
is always a string.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1054038/
Backport of #9584.
/cc @jstedfast