This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As expected the bundling of the old assembly breaks us :) We'll need to complete MonoDevelop's bump to master! |
This commit removes these binaries from our insertion https://github.com/xamarin/designer/pull/1840 |
alanmcgovern
force-pushed
the
proppertypanel-rebase
branch
from
March 21, 2019 09:56
653f2a0
to
ab383cc
Compare
I removed 653f2a0 from this PR as the md-addins PR has already merged :) |
nice! thank you @alanmcgovern ! |
alanmcgovern
force-pushed
the
proppertypanel-rebase
branch
from
March 27, 2019 12:56
b29d30d
to
de4c0e4
Compare
I disabled the DirectoryPathPropertyInfo as it does not seem like it's necessary in the version of the control which was merged.
netonjm
force-pushed
the
proppertypanel-rebase
branch
from
March 27, 2019 15:55
9a674a0
to
b9739e4
Compare
Fixed in master-vnext? |
yes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- PLEASE DO NOT MERGE -- We also need some code in ProppyEditing project to fix a problem of dupplicated resources
xamarin/Xamarin.PropertyEditing#566
This PR bumps the current branch in Xamarin.ProppertyEditing to the most recent hash
https://github.com/xamarin/Xamarin.PropertyEditing/compare/monodevelop-rebased
We are not based in current master because to build we had dependencies on the Editors and they are not merged in master yet. Because all these changes in the PR are cosmetical but we need work into our MD implementation, I created a branch which is based in master and I cherrypicked all the commits:
https://github.com/xamarin/Xamarin.PropertyEditing/tree/monodevelop-rebased
Once we do the desired cosmetical changes or fixes to the current PR's opened, validated and merged I will bump MD to point current master, what I would not have to be traumatic, since we always have the branch rebased.
Story case:
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/807788
=================== HOW INSTALL ======================
This PR includes a build with the native property editor integrated.
Easy than download and install it. The native replaces the old Gtk property editor.
To enable the feature you will need to enable the feature with:
export MD_FEATURES_ENABLED=NativePropertyPanel
Proppy Editors
[Mac] Adds implementation of FilePathEditorControl xamarin/Xamarin.PropertyEditing#479
[Mac] Adds implementation to handle char types xamarin/Xamarin.PropertyEditing#473
[Mac] Adds implementation to handle DateTime fields xamarin/Xamarin.PropertyEditing#480
[Mac] Adds implementation to handle TimeSpan types xamarin/Xamarin.PropertyEditing#477
Proppy specific issues/missing features:
Hide Header section (Name/type fields) in API xamarin/Xamarin.PropertyEditing#485