Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeBSD build break #57

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix FreeBSD build break #57

wants to merge 2 commits into from

Conversation

Thefrank
Copy link

@Thefrank Thefrank commented Nov 9, 2024

sys/extattr.h was failing check_include_file_cxx as it needs an addition header to build.
This also rolls PR #17 into this PR as it fixes some GCC-isms in the BSD section.

@Thefrank
Copy link
Author

Thefrank commented Nov 9, 2024

Other notes while I wait for checks:
Tests only support netcoreapp3.1 and net6 which are both end of service. To run the tests, I had to make changes which are not committed here (e.g., move to net8, override warnings, add FreeBSD to build.sh)

Two test failures that I would like to see if I can fix before removing WIP.
Test report in both trx and html are zipped and attached for those wanting to take a look.

Mono.Unix.Tests_net8.0_x64.zip

@akoeplinger
Copy link
Member

Tests only support netcoreapp3.1 and net6 which are both end of service.

Yeah we can move tests to net8.0

@Thefrank Thefrank marked this pull request as ready for review November 18, 2024 19:54
@Thefrank
Copy link
Author

This should be enough for now. It unbreaks FreeBSD but does not make any other change that might be breaking like moving tests to net8. The ipv6 test failure appears to be environment and how FreeBSD exposes information into jails. The other failure, fails the same way on OSX.

Github still lacks runners for FreeBSD and the current workarounds for getting FreeBSD into a Github runner significantly add to test run times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants