This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
[Atk] Fix property names. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atk defines the properties via const strings, not literal strings, so the perl parser grabs the wrong id. https://github.com/GNOME/atk/blob/125dac528339267821dbbd6da9b19fe9949334e9/atk/atkobject.c#L259-L273
iainx
reviewed
Aug 25, 2017
atk/Atk.metadata
Outdated
| <attr path="/api/namespace/object[@cname='AtkObject']/*[@name='AtkObjectNamePropertyValue']" name="cname">accessible-value</attr> | ||
| <attr path="/api/namespace/object[@cname='AtkObject']/*[@name='AtkObjectNamePropertyRole']" name="cname">accessible-role</attr> | ||
| <attr path="/api/namespace/object[@cname='AtkObject']/*[@name='AtkObjectNamePropertyComponentLayer']" name="cname">accessible-component-layer</attr> | ||
| <attr path="/api/namespace/object[@cname='AtkObject']/*[@name='AtkObjectNamePropertyMdiZorder']" name="cname">accessible-mdi-zorder</attr> |
There was a problem hiding this comment.
AtkObjectNamePropertyComponentMdiZorder too
iainx
reviewed
Aug 25, 2017
atk/Atk.metadata
Outdated
| <attr path="/api/namespace/object[@cname='AtkObject']/*[@name='AtkObjectNamePropertyTableRowHeader']" name="cname">accessible-row-header</attr> | ||
| <attr path="/api/namespace/object[@cname='AtkObject']/*[@name='AtkObjectNamePropertyTableSummary']" name="cname">accessible-table-summary</attr> | ||
| <attr path="/api/namespace/object[@cname='AtkObject']/*[@name='AtkObjectNamePropertyTableCaptionObject']" name="cname">accessible-table-caption-object</attr> | ||
| <attr path="/api/namespace/object[@cname='AtkObject']/*[@name='AtkObjectNamePropertyTableHypertextNumLinks']" name="cname">accessible-table-hypertext-nlinks</attr> |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atk defines the properties via const strings, not literal strings, so the perl parser grabs the wrong id. https://github.com/GNOME/atk/blob/125dac528339267821dbbd6da9b19fe9949334e9/atk/atkobject.c#L259-L273