Set value refactoring #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that wraps target process exception that occurred during runtime call. This allows to inspect exception objects in watch window if eval thrown an exception.
…lows to properly show an exception occurred during property evaluation.
Ignore eval exceptions occured during ToString() calls in type presentation
Better handling of exeptions in Soft invocations
…dateSessionState() is invoked (in finally) (cherry picked from commit 3befe19)
… for many times. Maybe this may help to avoid hanging evaluations. (Moved from MD repo)
nerzhulart
force-pushed
the
setValueRefactoring
branch
from
94b6322
to
6e14dfe
Compare
…modification is failed instead of supressing the exception. This allows to show the error info to user at the call site (e.g. in message box). ValueReference.SetValue() and ArrayElementGroup.SetValue() implementations unified and moved to ValueModificationUtil. (cherry picked from commit 316b7cc)
Documentation updated. (cherry picked from commit fdffbaa)
…shown in watch view (cherry picked from commit abcd933)
(cherry picked from commit 2e51f2e)
…ence (cherry picked from commit 31019a1)
nerzhulart
force-pushed
the
setValueRefactoring
branch
from
6e14dfe
to
e6f8fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues with SetValue:
SetValue now throws special exception (ValueModificationException) to be shown to user in frienly way. Before in the most of cases it failed silently without any errors.
NOTE: #85 has to be merged first, because this change is dependent on that
See commits starting from da12417