Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: options for DllImport and LibraryImport #1862

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

kumja1
Copy link

@kumja1 kumja1 commented Aug 22, 2024

Resolves issue #1687

@kumja1
Copy link
Author

kumja1 commented Aug 22, 2024

@dotnet-policy-service agree

@kumja1 kumja1 marked this pull request as draft August 23, 2024 09:28
@tritao tritao marked this pull request as ready for review August 27, 2024 22:08
@tritao
Copy link
Collaborator

tritao commented Aug 29, 2024

The build is failing:

CSharpTypePrinter.cs(612,65): error CS1001: Identifier expected [/home/runner/work/CppSharp/CppSharp/src/Generator/CppSharp.Generator.csproj]

@kumja1
Copy link
Author

kumja1 commented Sep 2, 2024

@tritao How would i regenerate the bindings for the cpp parser

@tritao
Copy link
Collaborator

tritao commented Sep 2, 2024

@kumja1 kumja1 marked this pull request as draft September 2, 2024 20:30
@kumja1
Copy link
Author

kumja1 commented Sep 5, 2024

@tritao strings are typically utf16 in native code correct? or are they different depending on the platform(like wchar_t is utf32 on linux)

@tritao
Copy link
Collaborator

tritao commented Sep 5, 2024

Yes they can be different depending on the platform or program.

It can be set as an option: https://github.com/mono/CppSharp/blob/main/src/Generator/Options.cs#L189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants