Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-484: Skip tests for OPS GENIE and GOV #937

Merged
merged 5 commits into from
Nov 29, 2022
Merged

INTMDB-484: Skip tests for OPS GENIE and GOV #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0bf177
Serverless Endpoint Service Doc Bug (#930)
Zuhairahmed Nov 17, 2022
1f0c12d
Update CHANGELOG.md
Zuhairahmed Nov 17, 2022
f246b7b
Skip broken OPS_GENIE token and GOV tests in main ACC test run
martinstibbe Nov 18, 2022
8ad6b85
make fmt
martinstibbe Nov 27, 2022
44c700f
Remove comment
martinstibbe Nov 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## [v1.6.0](https://github.com/mongodb/terraform-provider-mongodbatlas/tree/v1.6.0) (2022-11-16)
## [v1.6.0](https://github.com/mongodb/terraform-provider-mongodbatlas/tree/v1.6.0) (2022-11-17)

[Full Changelog](https://github.com/mongodb/terraform-provider-mongodbatlas/compare/v1.5.0...v1.6.0)

Expand Down
2 changes: 1 addition & 1 deletion mongodbatlas/provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func testAccPreCheckGov(t *testing.T) {
os.Getenv("MONGODB_ATLAS_PRIVATE_KEY") == "" ||
os.Getenv("MONGODB_ATLAS_PROJECT_ID_GOV") == "" ||
os.Getenv("MONGODB_ATLAS_ORG_ID_GOV") == "" {
t.Fatal("`MONGODB_ATLAS_PUBLIC_KEY_GOV`, `MONGODB_ATLAS_PRIVATE_KEY_GOV`, `MONGODB_ATLAS_PROJECT_ID_GOV` and `MONGODB_ATLAS_ORG_ID_GOV` must be set for acceptance testing")
t.Skip()
}
}

Expand Down
1 change: 1 addition & 0 deletions mongodbatlas/resource_mongodbatlas_third_party_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
)

func TestAccResourceMongoDBAtlasThirdPartyIntegration_basic(t *testing.T) {
t.Skip() // TODO: Address failures in API returning obfuscated values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great to add a CLOUDP link to this comment to track when this change will be done

var (
targetIntegration = matlas.ThirdPartyIntegration{}
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
Expand Down
4 changes: 2 additions & 2 deletions website/docs/r/privatelink_endpoint_service_serverless.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ resource "mongodbatlas_privatelink_endpoint_service_serverless" "test" {
project_id = "<PROJECT_ID>"
instance_name = mongodbatlas_serverless_instance.test.name
endpoint_id = mongodbatlas_privatelink_endpoint_serverless.test.endpoint_id
cloud_endpoint_id = aws_vpc_endpoint.ptfe_service.id
cloud_provider_endpoint_id = aws_vpc_endpoint.ptfe_service.id
provider_name = "AWS"
comment = "New serverless endpoint"
}
Expand Down Expand Up @@ -78,7 +78,7 @@ resource "mongodbatlas_privatelink_endpoint_service_serverless" "test" {
project_id = mongodbatlas_privatelink_endpoint_serverless.test.project_id
instance_name = mongodbatlas_serverless_instance.test.name
endpoint_id = mongodbatlas_privatelink_endpoint_serverless.test.endpoint_id
cloud_endpoint_id = azurerm_private_endpoint.test.id
cloud_provider_endpoint_id = azurerm_private_endpoint.test.id
private_endpoint_ip_address = azurerm_private_endpoint.test.private_service_connection.0.private_ip_address
provider_name = "AZURE"
comment = "test"
Expand Down