Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): add link to contribution guidelines in PR template #910

Conversation

Horgix
Copy link
Contributor

@Horgix Horgix commented Nov 9, 2022

Description

As a new contributor, I wondered where I could find the "Terraform contribution guidelines" mentioned in the Pull Requests template.

I ended up guessing it's about https://github.com/hashicorp/terraform/blob/main/.github/CONTRIBUTING.md

Considering that the linked-above guidelines are already linked in the current repository contribution guidelines (https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/CONTRIBUTING.md?plain=1#L11), this PR add a link to these guidelines and removes the "Terraform" mention.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

No relevant tests to run as far as I know.

Further comments

None.

@Horgix Horgix requested a review from a team as a code owner November 9, 2022 16:10
@Zuhairahmed Zuhairahmed self-requested a review November 9, 2022 18:17
Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Horgix! Also confirming that you signed our CLA, this is a good clarification update. LGTM

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This used to be the case but your fix is now accurate. TY

@Horgix
Copy link
Contributor Author

Horgix commented Nov 10, 2022

Thanks for the reviews! ☺️

What's the next step to get this merged? Do I need to do anything else on my end? 🙂

@Zuhairahmed Zuhairahmed merged commit dfcfb83 into mongodb:master Nov 10, 2022
@Zuhairahmed
Copy link
Collaborator

@Horgix just squashed and merged, thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants