Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-384 Fix PrivateLink test flakiness #895

Merged
merged 3 commits into from
Nov 8, 2022
Merged

INTMDB-384 Fix PrivateLink test flakiness #895

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f86983
Using different endpointID values for the endpoint service adl tests
evertsd Oct 31, 2022
beaad91
Removed parallelization with private link endpoint test which had ove…
evertsd Oct 31, 2022
8889ebb
Reverted changes to the endpointID
evertsd Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions mongodbatlas/resource_mongodbatlas_privatelink_endpoint_service_adl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func TestAccResourceMongoDBAtlasPrivateLinkEndpointServiceADL_basic(t *testing.T
commentUpdate = "this is a comment for adl private link endpoint UPDATED"
)

resource.ParallelTest(t, resource.TestCase{
resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
ProviderFactories: testAccProviderFactories,
CheckDestroy: testAccCheckMongoDBAtlasPrivateLinkEndpointServiceADLDestroy,
Expand Down Expand Up @@ -55,7 +55,7 @@ func TestAccResourceMongoDBAtlasPrivateLinkEndpointServiceADL_importBasic(t *tes
endpointID = "vpce-jjg5e24qp93513h03"
commentOrigin = "this is a comment for adl private link endpoint"
)
resource.ParallelTest(t, resource.TestCase{
resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
ProviderFactories: testAccProviderFactories,
CheckDestroy: testAccCheckMongoDBAtlasSearchIndexDestroy,
Expand Down Expand Up @@ -102,11 +102,11 @@ func testAccCheckMongoDBAtlasPrivateLinkEndpointServiceADLDestroy(state *terrafo
func testAccMongoDBAtlasPrivateLinkEndpointServiceADLConfig(projectID, endpointID, comment string) string {
return fmt.Sprintf(`
resource "mongodbatlas_privatelink_endpoint_service_adl" "test" {
project_id = "%[1]s"
endpoint_id = "%[2]s"
comment = "%[3]s"
type = "DATA_LAKE"
provider_name = "AWS"
project_id = "%[1]s"
endpoint_id = "%[2]s"
comment = "%[3]s"
type = "DATA_LAKE"
provider_name = "AWS"
}
`, projectID, endpointID, comment)
}
Expand Down