Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create index error msg #824

Merged

Conversation

ebouther
Copy link
Contributor

@ebouther ebouther commented Sep 5, 2022

Description

Fixed create index error message.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themantissa themantissa self-requested a review September 7, 2022 21:59
@themantissa
Copy link
Collaborator

@ebouther great catch, thank you! Are you sure you signed the CLA? I checked the list but do not see your github id. Also we may have to modify this - we currently merge changes to a release branch before master (https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/CONTRIBUTING.md), just fyi.

@ebouther ebouther changed the base branch from master to release-staging-v1.4.6 September 8, 2022 11:39
@ebouther
Copy link
Contributor Author

ebouther commented Sep 8, 2022

@themantissa it should be ok now for the CLA.

@themantissa
Copy link
Collaborator

Thank you @ebouther for signing.

@gssbzn gssbzn merged commit 6a282ba into mongodb:release-staging-v1.4.6 Sep 14, 2022
themantissa pushed a commit that referenced this pull request Sep 15, 2022
* Add support for use_org_and_group_names_in_export_prefix parameter (#829)

* INTMDB-381: Add support to ignore export bucket when auto_export_enabled = false (#823)

* Add support to ignore export bucket when auto_export_enabled = false

* Update mongodbatlas/resource_mongodbatlas_cloud_backup_schedule.go

Co-authored-by: Andrea Angiolillo <[email protected]>

* go fmt

* go fmt

Co-authored-by: Andrea Angiolillo <[email protected]>

* INTMDB-354: [Terraform] Update docs around what requires an API key access list (#834)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-354: [Terraform] Update docs around what requires an API key access list

* Expand detail in documentation for API key list

* Add additional resources that require API Key access list

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-383:  [Terraform] Update the BYOK/encryption at rest resource (#832)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update key rotation alert to 90 days vs 365

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-363: [Updated Feature] Add serverless backup to mongodbatlas_serverless_instance (#830)

* Add support for ServerlessContinuousBackupEnabled

* Update datasources, tests and documentation

* Update docs add link for backup information

* INTMDB-342: [Terraform] Update TestAccDataSourceMongoDBAtlasPrivateEndpointRegionalMode_basic test to use a new project to prevent conflicts  (#837)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* MONGODB_ATLAS_NETWORK_PROJECT_ID to permit multi region testing to run in different project

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update tests related to alert configuratiopn (#836)

* INTMDB-387: Enable Azure NVME for Atlas Dedicated clusters (#833)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add Azure as validation candidate for NVME

* Split out Azure setting

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: Fix create index error msg (#824)

* INTMDB-386 Defer project_invitation role validation to api (#840)

* Update project_invitation documentation and removed validations on roles

* Updated role documentation on project_invitation

* Added role documentation onto the argument reference

* INTMDB-347: [Terraform] cloud_backup is not being correctly imported - issue 768 (#839)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add support to migrate  legacy backup parameter to cloud_backup value

* Update error message

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-358: [terraform] Upgrade to go1.18 (#835)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update build to go 1.18

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-371: PrivateLink Endpoint Timeout (#841)

* Updated privatelink_endpoint CD endpoints to match refresh func timeout

* Using Configured timeout times in refresh func

* Updated docs to contain timeout instructions

* Corrected default timeout value on privatelink_endpoint

* Moved the timeout documentation to the resource

* PrivateLink Endpoint documentation refers to the proper resource and includes an example

* Fixed casing on Private Endpoint

* Added to docs on how to learn more about timeouts

* Update CHANGELOG.md

* Add links

* Update CHANGELOG.md

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Andrea Angiolillo <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eliot Boutherin <[email protected]>
Co-authored-by: Dosty Everts <[email protected]>
martinstibbe added a commit that referenced this pull request Sep 16, 2022
* Add support for use_org_and_group_names_in_export_prefix parameter (#829)

* INTMDB-381: Add support to ignore export bucket when auto_export_enabled = false (#823)

* Add support to ignore export bucket when auto_export_enabled = false

* Update mongodbatlas/resource_mongodbatlas_cloud_backup_schedule.go

Co-authored-by: Andrea Angiolillo <[email protected]>

* go fmt

* go fmt

Co-authored-by: Andrea Angiolillo <[email protected]>

* INTMDB-354: [Terraform] Update docs around what requires an API key access list (#834)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-354: [Terraform] Update docs around what requires an API key access list

* Expand detail in documentation for API key list

* Add additional resources that require API Key access list

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-383:  [Terraform] Update the BYOK/encryption at rest resource (#832)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update key rotation alert to 90 days vs 365

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-363: [Updated Feature] Add serverless backup to mongodbatlas_serverless_instance (#830)

* Add support for ServerlessContinuousBackupEnabled

* Update datasources, tests and documentation

* Update docs add link for backup information

* INTMDB-342: [Terraform] Update TestAccDataSourceMongoDBAtlasPrivateEndpointRegionalMode_basic test to use a new project to prevent conflicts  (#837)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* MONGODB_ATLAS_NETWORK_PROJECT_ID to permit multi region testing to run in different project

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update tests related to alert configuratiopn (#836)

* INTMDB-387: Enable Azure NVME for Atlas Dedicated clusters (#833)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add Azure as validation candidate for NVME

* Split out Azure setting

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: Fix create index error msg (#824)

* INTMDB-386 Defer project_invitation role validation to api (#840)

* Update project_invitation documentation and removed validations on roles

* Updated role documentation on project_invitation

* Added role documentation onto the argument reference

* INTMDB-347: [Terraform] cloud_backup is not being correctly imported - issue 768 (#839)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add support to migrate  legacy backup parameter to cloud_backup value

* Update error message

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-358: [terraform] Upgrade to go1.18 (#835)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update build to go 1.18

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-371: PrivateLink Endpoint Timeout (#841)

* Updated privatelink_endpoint CD endpoints to match refresh func timeout

* Using Configured timeout times in refresh func

* Updated docs to contain timeout instructions

* Corrected default timeout value on privatelink_endpoint

* Moved the timeout documentation to the resource

* PrivateLink Endpoint documentation refers to the proper resource and includes an example

* Fixed casing on Private Endpoint

* Added to docs on how to learn more about timeouts

* Update CHANGELOG.md

* Add links

* Update CHANGELOG.md

* Remove Azure unrelated EBS encryption flag for NVME disks

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Andrea Angiolillo <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eliot Boutherin <[email protected]>
Co-authored-by: Dosty Everts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants