Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus third party integration #745

Closed

Conversation

dgo-
Copy link

@dgo- dgo- commented Jun 1, 2022

Description

In this pull request I added support for the third party prometheus integration.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

The change itself will not break something, but I had to upgrade go.mongodb.org/atlas to v0.16.0, because it introduces support for the prometheus integration.

@themantissa
Copy link
Collaborator

@dgo- appreciate the hard work you've put into this but we already completed this and it will be in our next release when we are done with others features (#706). Expect it in the near term. Thank you!

@themantissa themantissa closed this Jun 2, 2022
@gssbzn gssbzn added the duplicate This issue or pull request already exists label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants