INTMDB-313: Update the project resource with new settings #741

martinstibbe · 2022-05-27T17:18:29Z

Description

Update the project resource with new settings feature

Link to any related issue(s):
https://jira.mongodb.org/browse/INTMDB-313

Type of change:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the Terraform contribution guidelines
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code

Further comments

…vider-mongodbatlas into INTMDB-313

andreaangiolillo · 2022-05-30T14:35:30Z

mongodbatlas/data_source_mongodbatlas_project.go

+			"is_collect_database_specifics_statistics_enabled": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},


[q] Could you update the tests with these new fields?

Tests added

Could you show me where? I do not see them

Apologies SDK had these will add to datasource

Added tests to datasource to verify new attributes exist

mongodbatlas/resource_mongodbatlas_project.go

andreaangiolillo · 2022-06-02T07:21:59Z

mongodbatlas/data_source_mongodbatlas_project.go

+			"is_collect_database_specifics_statistics_enabled": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},


Could you show me where? I do not see them

themantissa

Just some docs changes. Made suggestions for all so hopefully not too painful. TY!

themantissa · 2022-06-02T21:40:58Z

website/docs/d/project.html.markdown

@@ -96,4 +96,11 @@ The following are valid roles:
  * `GROUP_DATA_ACCESS_READ_ONLY`
  * `GROUP_CLUSTER_MANAGER`

+
+* `is_collect_database_specifics_statistics_enabled` - Flag that indicates whether to enable statistics in cluster metrics collection for the project.


Suggested change

* `is_collect_database_specifics_statistics_enabled` - Flag that indicates whether to enable statistics in cluster metrics collection for the project.

* `is_collect_database_specifics_statistics_enabled` - Flag that indicates whether to enable statistics in [cluster metrics](https://www.mongodb.com/docs/atlas/monitor-cluster-metrics/) collection for the project.

themantissa · 2022-06-02T21:41:31Z

website/docs/d/project.html.markdown

+* `is_data_explorer_enabled` - Flag that indicates whether to enable Data Explorer for the project. If enabled, you can query your database with an easy to use interface.
+* `is_performance_advisor_enabled` - Flag that indicates whether to enable Performance Advisor and Profiler for the project. If enabled, you can analyze database logs to recommend performance improvements.
+* `is_realtime_performance_panel_enabled` - Flag that indicates whether to enable Real Time Performance Panel for the project. If enabled, you can see real time metrics from your MongoDB database.
+* `is_schema_advisor_enabled` - Flag that indicates whether to enable Schema Advisor for the project. If enabled, you receive customized recommendations to optimize your data model and enhance performance. Disable this setting to disable schema suggestions in the Performance Advisor and the Data Explorer.


Suggested change

* `is_schema_advisor_enabled` - Flag that indicates whether to enable Schema Advisor for the project. If enabled, you receive customized recommendations to optimize your data model and enhance performance. Disable this setting to disable schema suggestions in the Performance Advisor and the Data Explorer.

* `is_schema_advisor_enabled` - Flag that indicates whether to enable Schema Advisor for the project. If enabled, you receive customized recommendations to optimize your data model and enhance performance. Disable this setting to disable schema suggestions in the [Performance Advisor](https://www.mongodb.com/docs/atlas/performance-advisor/#std-label-performance-advisor) and the [Data Explorer](https://www.mongodb.com/docs/atlas/atlas-ui/#std-label-atlas-ui).

themantissa · 2022-06-02T21:42:15Z

website/docs/d/projects.html.markdown

+* `is_data_explorer_enabled` - Flag that indicates whether to enable Data Explorer for the project. If enabled, you can query your database with an easy to use interface.
+* `is_performance_advisor_enabled` - Flag that indicates whether to enable Performance Advisor and Profiler for the project. If enabled, you can analyze database logs to recommend performance improvements.
+* `is_realtime_performance_panel_enabled` - Flag that indicates whether to enable Real Time Performance Panel for the project. If enabled, you can see real time metrics from your MongoDB database.
+* `is_schema_advisor_enabled` - Flag that indicates whether to enable Schema Advisor for the project. If enabled, you receive customized recommendations to optimize your data model and enhance performance. Disable this setting to disable schema suggestions in the Performance Advisor and the Data Explorer.


Suggested change

* `is_schema_advisor_enabled` - Flag that indicates whether to enable Schema Advisor for the project. If enabled, you receive customized recommendations to optimize your data model and enhance performance. Disable this setting to disable schema suggestions in the Performance Advisor and the Data Explorer.

* `is_schema_advisor_enabled` - Flag that indicates whether to enable Schema Advisor for the project. If enabled, you receive customized recommendations to optimize your data model and enhance performance. Disable this setting to disable schema suggestions in the [Performance Advisor](https://www.mongodb.com/docs/atlas/performance-advisor/#std-label-performance-advisor) and the [Data Explorer](https://www.mongodb.com/docs/atlas/atlas-ui/#std-label-atlas-ui).

themantissa · 2022-06-02T21:42:37Z

website/docs/d/projects.html.markdown

@@ -76,5 +76,9 @@ The following are valid roles:
  * `GROUP_DATA_ACCESS_READ_ONLY`
  * `GROUP_CLUSTER_MANAGER`

-
+* `is_collect_database_specifics_statistics_enabled` - Flag that indicates whether to enable statistics in cluster metrics collection for the project.


Suggested change

* `is_collect_database_specifics_statistics_enabled` - Flag that indicates whether to enable statistics in cluster metrics collection for the project.

* `is_collect_database_specifics_statistics_enabled` - Flag that indicates whether to enable statistics in [cluster metrics](https://www.mongodb.com/docs/atlas/monitor-cluster-metrics/) collection for the project.

themantissa · 2022-06-02T21:43:35Z

website/docs/r/project.html.markdown

+* `is_data_explorer_enabled` - (Optional) Flag that indicates whether to enable Data Explorer for the project. If enabled, you can query your database with an easy to use interface.
+* `is_performance_advisor_enabled` - (Optional) Flag that indicates whether to enable Performance Advisor and Profiler for the project. If enabled, you can analyze database logs to recommend performance improvements.
+* `is_realtime_performance_panel_enabled` - (Optional) Flag that indicates whether to enable Real Time Performance Panel for the project. If enabled, you can see real time metrics from your MongoDB database.
+* `is_schema_advisor_enabled` - (Optional) Flag that indicates whether to enable Schema Advisor for the project. If enabled, you receive customized recommendations to optimize your data model and enhance performance. Disable this setting to disable schema suggestions in the Performance Advisor and the Data Explorer.


Suggested change

* `is_schema_advisor_enabled` - (Optional) Flag that indicates whether to enable Schema Advisor for the project. If enabled, you receive customized recommendations to optimize your data model and enhance performance. Disable this setting to disable schema suggestions in the Performance Advisor and the Data Explorer.

* `is_schema_advisor_enabled` - (Optional) Flag that indicates whether to enable Schema Advisor for the project. If enabled, you receive customized recommendations to optimize your data model and enhance performance. Disable this setting to disable schema suggestions in the [Performance Advisor](https://www.mongodb.com/docs/atlas/performance-advisor/#std-label-performance-advisor) and the [Data Explorer](https://www.mongodb.com/docs/atlas/atlas-ui/#std-label-atlas-ui).

themantissa · 2022-06-02T21:48:08Z

website/docs/r/project.html.markdown

+  * `GROUP_CLUSTER_MANAGER`  
+
+* `is_collect_database_specifics_statistics_enabled` - (Optional) Flag that indicates whether to enable statistics in cluster metrics collection for the project.
+* `is_data_explorer_enabled` - (Optional) Flag that indicates whether to enable Data Explorer for the project. If enabled, you can query your database with an easy to use interface.


Suggested change

* `is_data_explorer_enabled` - (Optional) Flag that indicates whether to enable Data Explorer for the project. If enabled, you can query your database with an easy to use interface.

* `is_data_explorer_enabled` - (Optional) Flag that indicates whether to enable Data Explorer for the project. If enabled, you can query your database with an easy to use interface. When Data Explorer is disabled, you cannot terminate slow operations from the [Real-Time Performance Panel](https://www.mongodb.com/docs/atlas/real-time-performance-panel/#std-label-real-time-metrics-status-tab) or create indexes from the [Performance Advisor](https://www.mongodb.com/docs/atlas/performance-advisor/#std-label-performance-advisor). You can still view Performance Advisor recommendations, but you must create those indexes from [mongosh](https://www.mongodb.com/docs/mongodb-shell/#mongodb-binary-bin.mongosh).

themantissa · 2022-06-02T21:48:42Z

website/docs/r/project.html.markdown

-
+  * `GROUP_CLUSTER_MANAGER`  
+
+* `is_collect_database_specifics_statistics_enabled` - (Optional) Flag that indicates whether to enable statistics in cluster metrics collection for the project.


Suggested change

* `is_collect_database_specifics_statistics_enabled` - (Optional) Flag that indicates whether to enable statistics in cluster metrics collection for the project.

* `is_collect_database_specifics_statistics_enabled` - (Optional) Flag that indicates whether to enable statistics in [cluster metrics](https://www.mongodb.com/docs/atlas/monitor-cluster-metrics/) collection for the project.

…vider-mongodbatlas into INTMDB-313

themantissa

Beautiful. Thank you!

* INTMDB-310: Potential bug when disabling auditing (#705) * Add support for proper destroy of Auditing settings * Remove whitespace * Add support for schema migration (#717) * Correct import function for snapshot export bucket (#715) * INTMDB-311: Feature Add: Prometheus and Microsoft Team to the Third Party Integration Settings (#706) * INTMDB-311: Feature Add: Promethus and Microsoft Team to the Third Party Integration Settings * Update documentation add additional schema values * Map to temporary branch for testing * Fix Lint * Add boolean field for Prometheus enabled * Remove Name from Teams integration * Remove extra Name field from Teams integration type add examples * Terraform fmt * Correct version * Fix lint issue * terraform fmt example * Update third party integration resource enabled to boolean * Rename example file * Simplify example to integration only Doc updates password optional field * INTMDB-328: Update resource & data source to address change in go SDK that impacts resource_mongodbatlas_x509_authentication_database_user (#738) * Chore(deps): Bump actions/setup-go from 2 to 3 (#710) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/gruntwork-io/terratest (#711) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.6 to 0.40.7. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.6...v0.40.7) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump hashicorp/setup-terraform from 1 to 2 (#719) Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 1 to 2. - [Release notes](https://github.com/hashicorp/setup-terraform/releases) - [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md) - [Commits](hashicorp/setup-terraform@v1...v2) --- updated-dependencies: - dependency-name: hashicorp/setup-terraform dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/hashicorp/terraform-plugin-sdk/v2 (#720) Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.12.0 to 2.14.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.12.0...v2.14.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/hashicorp/terraform-plugin-sdk/v2 (#727) Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.14.0 to 2.16.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.14.0...v2.16.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/gruntwork-io/terratest (#726) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.7 to 0.40.8. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.7...v0.40.8) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/spf13/cast from 1.4.1 to 1.5.0 (#730) Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.4.1 to 1.5.0. - [Release notes](https://github.com/spf13/cast/releases) - [Commits](spf13/cast@v1.4.1...v1.5.0) --- updated-dependencies: - dependency-name: github.com/spf13/cast dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add default empty option list to fix breaking change for X509 certificates library function * Remove empty options := matlas.ListOptions Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-319: Add support for parameter unordered in resource_mongodbatlas_event_trigger (#739) * Add support for unordered realm parameter * Make unordered optional parameter * Update GO SDK to master * Sync to latest SDK library version * Update documentation for unordered parameter * Add support for unordered to tests * Chore(deps): Bump github.com/gruntwork-io/terratest (#744) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.10 to 0.40.12. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.10...v0.40.12) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/hashicorp/terraform-plugin-sdk/v2 (#743) Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.16.0 to 2.17.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.16.0...v2.17.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Melissa Plunkett <[email protected]> * INTMDB-321: Add support for cloud export backup to mongodbatlas_cloud_backup_schedule (#740) * Sync to go SDK * Correct lint error * Lint space * Update docs to include auto export and use_org_and_group_names_in_export_prefix * Add link for snapshot export * Rename to emptyStruct * Add brackets to hyperlink * Remove extra space * INTMDB-313: Update the project resource with new settings (#741) * Add support for project_settings * Sync up SDK library latest version * Fix lint isues * Update projects datasource documentation * Update docs with links * Add additional tests for new attributes remove space in import section * Add test for additional project settings * INTMDB-307 Allow setting of regional mode setting on a group (#718) * Started on private_endpoint_regional_mode data_source and resource * Started filling out test and wrote refresh func to ensure cluster status' are all at APPLIED * No longer reading the setting in refresh func * Removed unused testing infrastructure * Fixed data_source test for private endpoint regional mode * Fixed how regional mode refresh func is consumed * Fixed resource name on new test * Added resource and data source to the provider, fixed other build issues * Fixed lint errors * Setting key for private endpoint regional mode as just the projectID * Fixed failing test for private endpoint regional mode. Still need to add a cluster to the config * Added assertion that cluster connection_strings are maintained properly in state * Added example for regional mode and update delay before checking refresh func * Checking if cluster is in the UPDATING state prior to checking against the cluster statsu * Added dependency on regional mode for the cluster data * Updated regional mode example to have usage documentation. Updated integration test to create more of its dependencies during the test * Format example for aws-atlas-privatelink-regionalized * Fixed an issue with tflint * Update regional mode test to spin up vpc requirements * Added documentation and updated example to have two separate private endpoints * Updated example to have regional_mode enabled * Updated Project ID refs in documentation to match others in example tf * Revert "Update regional mode test to spin up vpc requirements" This reverts commit 3f5893c. * Fixed formatting on example tf * Let code breathe in example atlas cluster Co-authored-by: Andrea Angiolillo <[email protected]> * Use proper error and log messaging, utilize diag.Errorf * Update website/docs/r/private_endpoint_regional_mode.html.markdown Co-authored-by: Melissa Plunkett <[email protected]> * Update enabled description in docs to contain more of the api documentation Co-authored-by: Melissa Plunkett <[email protected]> * Update website/docs/r/private_endpoint_regional_mode.html.markdown Co-authored-by: Melissa Plunkett <[email protected]> * Link to registry docs not our github repo Co-authored-by: Melissa Plunkett <[email protected]> * Updated assertions in tests * Updated example to be more current and accurate. Fixed test * Updated private endpoint regional mode to be disabled on delete * Made enabled properly optional for private endpoitn regional mode and made data_source test replicate actual usage Co-authored-by: admin <[email protected]> Co-authored-by: Andrea Angiolillo <[email protected]> Co-authored-by: Melissa Plunkett <[email protected]> * INTDB-301-DOC: Move Federated Docs to separate branch (#747) * Move Federated Docs to separate branch PR * Add docs for new datasources and updated role mappings resource * Refactor okta_idp_id to idp_id in docs * Add additional parameters for identity provider resource * Removed cloud from much of the docs * Applied group id description changes * Addressed more suggested docs changes * Downcased federated settings * Make role mapping import optional add missing formatting for example * Highlight importance of import being needed * Changed Provides an to provides a and remove upper case on federated settings * Update identity_provider datasource * Missed one * Add SHA-256 * Fix post_auth_role_grants * Doc corrections * remove pagination from singular role mapping * Import needed * Doc updates * Update org settings resource to pull up required args * Add import statement importance Co-authored-by: Dosty <[email protected]> * INTMDB-301: Feature add: Add support for managment of federated authentication configuration (#742) * Add support for federated settings * Refactor for service pattern change * Refactor options and plural singular names * Update go SDK version * Add initial federated website docs * Provide examples for Federated settings * Sync go.mod to contain breaking change SDK change * Fix examples for lint error sync SDK to master * Add menu items for federation settings and upgrade guides * Remove Federated Docs from PR * PR Review updates * Add support for datasource tests * Fix lint fmt * Add identity_provider_id variable * Move identity_provider_id * Add role mappings datasource test * Add additional tests for federated resources * Lint check * Add additional datasources and tests * Remove unused function * Add support for role mappings and update tests and examples * Fix role mapping import to fit new style of parameters * Remove commented code * go mod tidy * Remove extra parameter user_conflicts * Add missing parameters and refactor name of variables * Update example * Update mongodbatlas/resource_mongodbatlas_federated_settings_identity_provider.go Co-authored-by: Andrea Angiolillo <[email protected]> * go fmt * Add support for import tests * Add federated settings env variables to README remove upgrade guide * Remove cloud prefix from federated examples and resources idp_id to okta_idp_id * Add new sort to role mapping * Add README for federated example * Refactor alias mongodbatlas to matlas dead code removal import spaces Co-authored-by: Andrea Angiolillo <[email protected]> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Melissa Plunkett <[email protected]> Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Andrea Angiolillo <[email protected]>

wyardley · 2022-07-06T17:17:42Z

I would argue this is, potentially, at least, breaking, and also would suggest maybe considering slightly tidier / shorter / easier to read parameter names here?

I commented more in #772

themantissa · 2022-07-06T18:10:29Z

@wyardley the intended behavior was not to be breaking. Let's continue this in #772

* INTMDB-310: Potential bug when disabling auditing (mongodb#705) * Add support for proper destroy of Auditing settings * Remove whitespace * Add support for schema migration (mongodb#717) * Correct import function for snapshot export bucket (mongodb#715) * INTMDB-311: Feature Add: Prometheus and Microsoft Team to the Third Party Integration Settings (mongodb#706) * INTMDB-311: Feature Add: Promethus and Microsoft Team to the Third Party Integration Settings * Update documentation add additional schema values * Map to temporary branch for testing * Fix Lint * Add boolean field for Prometheus enabled * Remove Name from Teams integration * Remove extra Name field from Teams integration type add examples * Terraform fmt * Correct version * Fix lint issue * terraform fmt example * Update third party integration resource enabled to boolean * Rename example file * Simplify example to integration only Doc updates password optional field * INTMDB-328: Update resource & data source to address change in go SDK that impacts resource_mongodbatlas_x509_authentication_database_user (mongodb#738) * Chore(deps): Bump actions/setup-go from 2 to 3 (mongodb#710) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/gruntwork-io/terratest (mongodb#711) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.6 to 0.40.7. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.6...v0.40.7) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump hashicorp/setup-terraform from 1 to 2 (mongodb#719) Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 1 to 2. - [Release notes](https://github.com/hashicorp/setup-terraform/releases) - [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md) - [Commits](hashicorp/setup-terraform@v1...v2) --- updated-dependencies: - dependency-name: hashicorp/setup-terraform dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/hashicorp/terraform-plugin-sdk/v2 (mongodb#720) Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.12.0 to 2.14.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.12.0...v2.14.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/hashicorp/terraform-plugin-sdk/v2 (mongodb#727) Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.14.0 to 2.16.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.14.0...v2.16.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/gruntwork-io/terratest (mongodb#726) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.7 to 0.40.8. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.7...v0.40.8) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/spf13/cast from 1.4.1 to 1.5.0 (mongodb#730) Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.4.1 to 1.5.0. - [Release notes](https://github.com/spf13/cast/releases) - [Commits](spf13/cast@v1.4.1...v1.5.0) --- updated-dependencies: - dependency-name: github.com/spf13/cast dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add default empty option list to fix breaking change for X509 certificates library function * Remove empty options := matlas.ListOptions Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-319: Add support for parameter unordered in resource_mongodbatlas_event_trigger (mongodb#739) * Add support for unordered realm parameter * Make unordered optional parameter * Update GO SDK to master * Sync to latest SDK library version * Update documentation for unordered parameter * Add support for unordered to tests * Chore(deps): Bump github.com/gruntwork-io/terratest (mongodb#744) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.10 to 0.40.12. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.10...v0.40.12) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Chore(deps): Bump github.com/hashicorp/terraform-plugin-sdk/v2 (mongodb#743) Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.16.0 to 2.17.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.16.0...v2.17.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Melissa Plunkett <[email protected]> * INTMDB-321: Add support for cloud export backup to mongodbatlas_cloud_backup_schedule (mongodb#740) * Sync to go SDK * Correct lint error * Lint space * Update docs to include auto export and use_org_and_group_names_in_export_prefix * Add link for snapshot export * Rename to emptyStruct * Add brackets to hyperlink * Remove extra space * INTMDB-313: Update the project resource with new settings (mongodb#741) * Add support for project_settings * Sync up SDK library latest version * Fix lint isues * Update projects datasource documentation * Update docs with links * Add additional tests for new attributes remove space in import section * Add test for additional project settings * INTMDB-307 Allow setting of regional mode setting on a group (mongodb#718) * Started on private_endpoint_regional_mode data_source and resource * Started filling out test and wrote refresh func to ensure cluster status' are all at APPLIED * No longer reading the setting in refresh func * Removed unused testing infrastructure * Fixed data_source test for private endpoint regional mode * Fixed how regional mode refresh func is consumed * Fixed resource name on new test * Added resource and data source to the provider, fixed other build issues * Fixed lint errors * Setting key for private endpoint regional mode as just the projectID * Fixed failing test for private endpoint regional mode. Still need to add a cluster to the config * Added assertion that cluster connection_strings are maintained properly in state * Added example for regional mode and update delay before checking refresh func * Checking if cluster is in the UPDATING state prior to checking against the cluster statsu * Added dependency on regional mode for the cluster data * Updated regional mode example to have usage documentation. Updated integration test to create more of its dependencies during the test * Format example for aws-atlas-privatelink-regionalized * Fixed an issue with tflint * Update regional mode test to spin up vpc requirements * Added documentation and updated example to have two separate private endpoints * Updated example to have regional_mode enabled * Updated Project ID refs in documentation to match others in example tf * Revert "Update regional mode test to spin up vpc requirements" This reverts commit 3f5893c. * Fixed formatting on example tf * Let code breathe in example atlas cluster Co-authored-by: Andrea Angiolillo <[email protected]> * Use proper error and log messaging, utilize diag.Errorf * Update website/docs/r/private_endpoint_regional_mode.html.markdown Co-authored-by: Melissa Plunkett <[email protected]> * Update enabled description in docs to contain more of the api documentation Co-authored-by: Melissa Plunkett <[email protected]> * Update website/docs/r/private_endpoint_regional_mode.html.markdown Co-authored-by: Melissa Plunkett <[email protected]> * Link to registry docs not our github repo Co-authored-by: Melissa Plunkett <[email protected]> * Updated assertions in tests * Updated example to be more current and accurate. Fixed test * Updated private endpoint regional mode to be disabled on delete * Made enabled properly optional for private endpoitn regional mode and made data_source test replicate actual usage Co-authored-by: admin <[email protected]> Co-authored-by: Andrea Angiolillo <[email protected]> Co-authored-by: Melissa Plunkett <[email protected]> * INTDB-301-DOC: Move Federated Docs to separate branch (mongodb#747) * Move Federated Docs to separate branch PR * Add docs for new datasources and updated role mappings resource * Refactor okta_idp_id to idp_id in docs * Add additional parameters for identity provider resource * Removed cloud from much of the docs * Applied group id description changes * Addressed more suggested docs changes * Downcased federated settings * Make role mapping import optional add missing formatting for example * Highlight importance of import being needed * Changed Provides an to provides a and remove upper case on federated settings * Update identity_provider datasource * Missed one * Add SHA-256 * Fix post_auth_role_grants * Doc corrections * remove pagination from singular role mapping * Import needed * Doc updates * Update org settings resource to pull up required args * Add import statement importance Co-authored-by: Dosty <[email protected]> * INTMDB-301: Feature add: Add support for managment of federated authentication configuration (mongodb#742) * Add support for federated settings * Refactor for service pattern change * Refactor options and plural singular names * Update go SDK version * Add initial federated website docs * Provide examples for Federated settings * Sync go.mod to contain breaking change SDK change * Fix examples for lint error sync SDK to master * Add menu items for federation settings and upgrade guides * Remove Federated Docs from PR * PR Review updates * Add support for datasource tests * Fix lint fmt * Add identity_provider_id variable * Move identity_provider_id * Add role mappings datasource test * Add additional tests for federated resources * Lint check * Add additional datasources and tests * Remove unused function * Add support for role mappings and update tests and examples * Fix role mapping import to fit new style of parameters * Remove commented code * go mod tidy * Remove extra parameter user_conflicts * Add missing parameters and refactor name of variables * Update example * Update mongodbatlas/resource_mongodbatlas_federated_settings_identity_provider.go Co-authored-by: Andrea Angiolillo <[email protected]> * go fmt * Add support for import tests * Add federated settings env variables to README remove upgrade guide * Remove cloud prefix from federated examples and resources idp_id to okta_idp_id * Add new sort to role mapping * Add README for federated example * Refactor alias mongodbatlas to matlas dead code removal import spaces Co-authored-by: Andrea Angiolillo <[email protected]> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Melissa Plunkett <[email protected]> Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Andrea Angiolillo <[email protected]>

martinstibbe added 2 commits May 24, 2022 19:26

Add support for project_settings

4704784

Sync up SDK library latest version

875f308

martinstibbe requested review from andreaangiolillo and themantissa as code owners May 27, 2022 17:18

martinstibbe added 4 commits May 27, 2022 12:19

Merge branch 'release-staging-v1.4.0' into INTMDB-313

189e7f7

Fix lint isues

1987853

Merge branch 'INTMDB-313' of https://github.com/mongodb/terraform-pro…

8394d28

…vider-mongodbatlas into INTMDB-313

Update projects datasource documentation

f065931

andreaangiolillo reviewed May 30, 2022

View reviewed changes

themantissa requested a review from andreaangiolillo May 31, 2022 21:11

andreaangiolillo reviewed Jun 2, 2022

View reviewed changes

themantissa requested changes Jun 2, 2022

View reviewed changes

martinstibbe added 2 commits June 2, 2022 17:00

Update docs with links

10ff080

Merge branch 'release-staging-v1.4.0' into INTMDB-313

74bd204

martinstibbe requested a review from themantissa June 2, 2022 22:02

martinstibbe added 2 commits June 2, 2022 19:47

Add additional tests for new attributes remove space in import section

7a74b12

Merge branch 'INTMDB-313' of https://github.com/mongodb/terraform-pro…

2f4786f

…vider-mongodbatlas into INTMDB-313

martinstibbe requested a review from andreaangiolillo June 3, 2022 00:53

Add test for additional project settings

ae64308

andreaangiolillo approved these changes Jun 3, 2022

View reviewed changes

themantissa approved these changes Jun 3, 2022

View reviewed changes

martinstibbe merged commit dc519e9 into release-staging-v1.4.0 Jun 3, 2022

martinstibbe deleted the INTMDB-313 branch June 3, 2022 23:51

wyardley mentioned this pull request Jul 6, 2022

Project settings in 1.4.0 incorrectly sets all options to false. #772

Closed

wyardley mentioned this pull request Jul 7, 2022

Provider defaults for parameters in provider version >= 1.4.1 #777

Closed

martinstibbe mentioned this pull request Jul 7, 2022

INTMDB-313: Set project settings to computed to ignore when not supplied by user #778

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

INTMDB-313: Update the project resource with new settings #741

INTMDB-313: Update the project resource with new settings #741

martinstibbe commented May 27, 2022 •

edited

Loading

andreaangiolillo May 30, 2022

martinstibbe Jun 2, 2022

andreaangiolillo Jun 2, 2022

martinstibbe Jun 2, 2022

martinstibbe Jun 3, 2022

andreaangiolillo Jun 2, 2022

themantissa left a comment

themantissa Jun 2, 2022

martinstibbe Jun 2, 2022

themantissa Jun 2, 2022

martinstibbe Jun 2, 2022

themantissa Jun 2, 2022

martinstibbe Jun 2, 2022

themantissa Jun 2, 2022

martinstibbe Jun 2, 2022

themantissa Jun 2, 2022

martinstibbe Jun 2, 2022

themantissa Jun 2, 2022

martinstibbe Jun 2, 2022

themantissa Jun 2, 2022

martinstibbe Jun 2, 2022

themantissa left a comment

wyardley commented Jul 6, 2022

themantissa commented Jul 6, 2022

	* `is_collect_database_specifics_statistics_enabled` - Flag that indicates whether to enable statistics in cluster metrics collection for the project.
	* `is_collect_database_specifics_statistics_enabled` - Flag that indicates whether to enable statistics in [cluster metrics](https://www.mongodb.com/docs/atlas/monitor-cluster-metrics/) collection for the project.


		* `GROUP_CLUSTER_MANAGER`

		* `is_collect_database_specifics_statistics_enabled` - (Optional) Flag that indicates whether to enable statistics in cluster metrics collection for the project.

INTMDB-313: Update the project resource with new settings #741

INTMDB-313: Update the project resource with new settings #741

Conversation

martinstibbe commented May 27, 2022 • edited Loading

Description

Type of change:

Required Checklist:

Further comments

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

themantissa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

themantissa left a comment

Choose a reason for hiding this comment

wyardley commented Jul 6, 2022

themantissa commented Jul 6, 2022

martinstibbe commented May 27, 2022 •

edited

Loading