Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown formatting in network_container.html.markdown #647

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

pmacey
Copy link
Contributor

@pmacey pmacey commented Jan 3, 2022

Description

Noticed that the markdown rendering was incorrect for the network container documentation, specifically where delimiting the cloud provider attributes references.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

To avoid noise, I did not create an issue for this minor change, happy to do so if required.

* Additional new lines for subheadings to fix formatting for cloud-specific attributes references
* Remove superfluous asterisk
@pmacey pmacey requested a review from themantissa as a code owner January 3, 2022 17:15
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @pmacey.

@themantissa themantissa merged commit 1439182 into mongodb:master Jan 6, 2022
@pmacey pmacey deleted the pmacey-fix-md branch January 25, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants