Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-283: Fixes a bug about optional parameters in Cloud Backup Schedule #631

Merged
merged 3 commits into from
Dec 19, 2021
Merged

INTMDB-283: Fixes a bug about optional parameters in Cloud Backup Schedule #631

merged 3 commits into from
Dec 19, 2021

Conversation

coderGo93
Copy link
Contributor

Description

  • Fixes a bug where it should be or not set in request if it's using or not for parameters in cloud backup schedule and avoid the error (request "INVALID_RESTORE_WINDOW") The restore window days should be a positive number
  • Added a testacc TestAccResourceMongoDBAtlasCloudBackupSchedule_azure

Link to any related issue(s):
#625

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Dec 7, 2021
andreaangiolillo
andreaangiolillo approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themantissa
themantissa approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

thetonymaster
thetonymaster approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Dec 18, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Dec 18, 2021
@coderGo93 coderGo93 merged commit ed4d2dd into master Dec 19, 2021
@coderGo93 coderGo93 deleted the INTMDB-283 branch December 19, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@thetonymaster thetonymaster thetonymaster approved these changes

@themantissa themantissa themantissa approved these changes

@abner-dou abner-dou Awaiting requested review from abner-dou

Assignees

@coderGo93 coderGo93

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coderGo93 @themantissa @thetonymaster @andreaangiolillo