INTMDB-200: Fixes a bug about updating a region name with GCP #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderGo93
changed the title
leofigy
approved these changes
May 21, 2021
added 2 commits
May 27, 2021 12:06
themantissa
requested review from
a team and
threebee
and removed request for
a team
| replaceRegion := "" | ||
| originalRegion := "" | ||
|
|
||
| if okPRName && d.Get("provider_name").(string) == "GCP" && cast.ToString(d.Get("cluster_type")) == "REPLICASET" { |
There was a problem hiding this comment.
[q] I am not sure why we have the check only for REPLICASET
There was a problem hiding this comment.
For my understanding, since the user created a basic cluster, it seems in response it creates automatically with cluster type REPLICASET along the replication specs , this why I added validation, for this special scenario
themantissa
reviewed
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the bug of
provider_region_nameare recognized but not applied properlyLink to any related issue(s):
Type of change:
Required Checklist:
Further comments