Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-205 fixing client update side effects #456

Merged
merged 1 commit into from
May 12, 2021
Merged

INTMDB-205 fixing client update side effects #456

merged 1 commit into from
May 12, 2021

Conversation

leofigy
Copy link
Contributor

@leofigy leofigy commented May 12, 2021 •
edited
Loading

Description

Hi @themantissa, @coderGo93 removing escaped from the provider because the client already does it

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@leofigy leofigy requested a review from coderGo93 as a code owner May 12, 2021 04:35
@leofigy leofigy self-assigned this May 12, 2021
@leofigy leofigy added the run-testacc To run acceptance tests label May 12, 2021
@leofigy leofigy requested a review from themantissa May 12, 2021 20:36
themantissa
themantissa approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Must have missed that getting added in.

@leofigy leofigy merged commit 7ba0438 into master May 12, 2021
@leofigy leofigy deleted the INTMDB-205-client-update-fixes branch May 12, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees

@leofigy leofigy

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leofigy @themantissa