Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test config update #454

Merged
merged 2 commits into from
May 11, 2021
Merged

Test config update #454

merged 2 commits into from
May 11, 2021

Conversation

leofigy
Copy link
Contributor

@leofigy leofigy commented May 11, 2021 •
edited
Loading

Description

Hello @themantissa , @coderGo93 Updating cluster test config, because it fails because the diff
Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@leofigy leofigy requested a review from coderGo93 as a code owner May 11, 2021 03:00
@leofigy leofigy self-assigned this May 11, 2021
@leofigy leofigy added the run-testacc To run acceptance tests label May 11, 2021
@leofigy leofigy requested a review from themantissa May 11, 2021 04:56
themantissa
themantissa requested changes May 11, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! Since it's not required I'd just remove it vs updating. Long term likely to be more sustainable.

mongodbatlas/data_source_mongodbatlas_cloud_provider_snapshot_backup_policy_test.go Outdated
@@ -41,7 +41,7 @@ func testAccMongoDBAtlasDataSourceCloudProviderSnapshotBackupPolicyConfig(projec
provider_region_name = "EU_CENTRAL_1"
provider_instance_size_name = "M10"
provider_backup_enabled = true //enable cloud provider snapshots
provider_disk_iops = 100
provider_disk_iops = 3000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't required. We recently removed it from the examples due to the issues with it and that it is not required, especially for M10s (where you can't set a higher iops than you get). I'd just remove it.

Copy link
Contributor Author

@leofigy leofigy May 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay that's even better :) removing it

@leofigy leofigy added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels May 11, 2021
@leofigy leofigy requested a review from themantissa May 11, 2021 19:50
themantissa
themantissa approved these changes May 11, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@leofigy leofigy merged commit 221ee96 into master May 11, 2021
@leofigy leofigy deleted the No-ticket-test-update branch May 11, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees

@leofigy leofigy

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leofigy @themantissa