INTMDB-155: Fixes a bug related to bi_connector cluster by deprecating

[coderGo93]

Description

• Deprecated the parameter bi_connector and added parameter bi_connector_config to avoid a behavior bug of update in change in terraform version 14
• Added test TestAccResourceMongoDBAtlasCluster_WithBiConnectorGCP

Link to any related issue(s):

Type of change:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the Terraform contribution guidelines
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code

Further comments

[themantissa]

Fixes #364

[leofigy]

LGTM, the Type List with max 1 did the work

[themantissa]

@coderGo93 so is this just part of the fix for #364 then? This would fix for those using bi connector but not for those just with it in state that I can see?

[coderGo93]

@themantissa It would fix for both, since it's different type now in schema like mentioned here and deprecated and it would require to re-apply to make changes in state since the bi_connector would be deprecated but after that it won't appear more changes in terraform version 14 like terraform v13 or before for bi_connector_config and the old parameter bi_connector would be ignored if not using otherwise it would get a warning about deprecation

[themantissa]

Thank you clarifying @coderGo93

[themantissa]

LGTM but just make sure we link the reporting issue so it closes once this is merged. Thanks!