Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-163: Wrong order for PrivateLink Endpoint Service and detects unnecessary changes #388

Merged
merged 5 commits into from
Jan 26, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Jan 23, 2021

Description

Private Endpoint (deprecated)

  • Added provider name and region in state id for import and read so it won't detect the unnecessary changes for region/provider name while plan after import

Private Endpoint Interface (deprecated)

  • Set the fields private link id and interface id in read so it can't detect unnecessary changes.

PrivateLink Endpoint

  • Added region in state id for import and other func(create, read and delete) so it it won't detect the unnecessary changes for region

PrivateLink Endpoint Service

  • Changed the wrong order, the field private_link_id was using with endpoint_service_id information instead of private_link_id from private_link_endpoint resource and vice versa(endpoint_service_id using with private_link_id info)
  • Set the fields private link id in read so it won't detect unnecessary changes.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Sorry, something went wrong.

Edgar López added 4 commits January 22, 2021 19:43
@coderGo93 coderGo93 self-assigned this Jan 23, 2021
@leofigy
Copy link
Contributor

leofigy commented Jan 23, 2021

Hi @coderGo93 LGTM, but before merging can you test the manually upgrade. in order to update the documentation steps.

  • Create one template with the deprecated resources using the V0.7.0
  • Update the terraform provider to build that contains this terraform fix
  • Perform the import procedure
  • At the end do a terraform plan, there should be no changes

Thanks in advance

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only change would be to ask if you could also update the import examples in the guide: https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/website/docs/guides/0.8.0-upgrade-guide.html.markdown so that we we get the whole fix in one PR? Thank you!

@coderGo93 coderGo93 requested a review from themantissa January 26, 2021 00:32
@themantissa themantissa changed the title NTMDB-163: Wrong order for PrivateLink Endpoint Service and detects unnecessary changes INTMDB-163: Wrong order for PrivateLink Endpoint Service and detects unnecessary changes Jan 26, 2021
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the guide.

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Jan 26, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Jan 26, 2021
@coderGo93 coderGo93 merged commit 785dee1 into master Jan 26, 2021
@coderGo93 coderGo93 deleted the INTMDB-163 branch January 26, 2021 03:33
@themantissa themantissa linked an issue Jan 26, 2021 that may be closed by this pull request
@Dani-Relic
Copy link

Hi, what's the estimation for releasing this fix

@themantissa
Copy link
Collaborator

@Dani-Relic we have one more bug to fix and then will get it out, should be soon.

@RalphBragg
Copy link

Can't wait!

@themantissa
Copy link
Collaborator

@RalphBragg @Dani-Relic v0.8.1 is out with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter mismatch in mongodbatlas_privatelink_endpoint_service
5 participants