-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTMDB-163: Wrong order for PrivateLink Endpoint Service and detects unnecessary changes #388
Conversation
…n import and read, and modified docs of how to import
…detecting changes while terraform plan after import
…avoid detecting unnecessary changes
… in private link service
Hi @coderGo93 LGTM, but before merging can you test the manually upgrade. in order to update the documentation steps.
Thanks in advance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only change would be to ask if you could also update the import examples in the guide: https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/website/docs/guides/0.8.0-upgrade-guide.html.markdown so that we we get the whole fix in one PR? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the guide.
Hi, what's the estimation for releasing this fix |
@Dani-Relic we have one more bug to fix and then will get it out, should be soon. |
Can't wait! |
@RalphBragg @Dani-Relic v0.8.1 is out with this fix. |
Description
Private Endpoint (deprecated)
Private Endpoint Interface (deprecated)
PrivateLink Endpoint
PrivateLink Endpoint Service
private_link_id
was using withendpoint_service_id
information instead ofprivate_link_id
from private_link_endpoint resource and vice versa(endpoint_service_id
using withprivate_link_id
info)Link to any related issue(s):
Type of change:
Required Checklist:
Further comments