Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Network container #38

Merged
merged 3 commits into from
Oct 1, 2019
Merged

Fix: Network container #38

merged 3 commits into from
Oct 1, 2019

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Sep 24, 2019

I added the refresh function to avoid error 409 from the server, and this happens due to the container wants to be removed when the provisioned attribute of the container is enabled, this means that the container is still in use. To avoid this issue the refresh function requests to the server to verify this attribute, so when the attribute change to disabled, then the container can be removed.

closes #30

@ghost ghost added the size/S label Sep 24, 2019
@PacoDw PacoDw changed the title Network container Fix: Network container Sep 24, 2019
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marinsalinas marinsalinas merged commit e651f1c into master Oct 1, 2019
@marinsalinas marinsalinas deleted the networkContainer branch October 1, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem destroying network peering container
3 participants