INTMDB-144: Updated for scopes database users #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themantissa
requested changes
Dec 21, 2020
go.mod
Outdated
| @@ -1,7 +1,7 @@ | |||
| module github.com/mongodb/terraform-provider-mongodbatlas | |||
|
|
|||
| go 1.14 | |||
|
|
|||
| replace go.mongodb.org/atlas => ../go-client-mongodb-atlas | |||
There was a problem hiding this comment.
Probably shouldn't leave, looks like for testing?
There was a problem hiding this comment.
Yes, so I can use the recent changes of client mongodb, since it's merged I will update from master mongodb client
themantissa
approved these changes
Dec 21, 2020
|
@marinsalinas or @leofigy can one of you review please? |
leofigy
reviewed
Jan 7, 2021
| v := val.(map[string]interface{}) | ||
| res[i] = matlas.Scope{ | ||
| scope := matlas.Scope{ |
coderGo93
added
run-testacc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scopesand send an array empty if not specifiedTestAccResourceMongoDBAtlasDatabaseUser_withScopesAndEmptyLink to any related issue(s):
Type of change:
Required Checklist:
Further comments
Waiting for PR to be merged then update the vendor from master and merge