Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: changelog v0.7.0 #343

Merged
merged 1 commit into from
Oct 22, 2020
Merged

chore: changelog v0.7.0 #343

merged 1 commit into from
Oct 22, 2020

Conversation

leofigy
Copy link
Contributor

@leofigy leofigy commented Oct 21, 2020

Description

Including changelog for the pre-release v0.7.0

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@leofigy leofigy requested review from themantissa and coderGo93 and removed request for coderGo93 October 21, 2020 16:35
@leofigy leofigy self-assigned this Oct 21, 2020
@leofigy leofigy added the run-testacc To run acceptance tests label Oct 21, 2020
@leofigy
Copy link
Contributor Author

leofigy commented Oct 21, 2020 •
edited
Loading

Hello, I've got a release draft, for this just running the acceptance tests, because the binaries generated from this tag are the ones in that pre-release. once it passes I'll mark it as public (the pre-release).

themantissa
themantissa approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

coderGo93
coderGo93 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leofigy leofigy merged commit ba8642a into master Oct 22, 2020
@leofigy leofigy deleted the chore-changelog-v0.7.0 branch January 13, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderGo93 coderGo93 coderGo93 approved these changes

@themantissa themantissa themantissa approved these changes

Assignees

@leofigy leofigy

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leofigy @themantissa @coderGo93