Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes a bug for issue 289 #323

Merged
merged 3 commits into from
Oct 3, 2020
Merged

fix: fixes a bug for issue 289 #323

merged 3 commits into from
Oct 3, 2020

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Sep 29, 2020

Description

WIP because couldn't replicate the error with indicated steps but it's probably related because the project id was not set in read and it detects "change" like in issue. There's has been a similar error with acceptance test for import, so I set it and the testacc for import worked

Link to any related issue(s):
#289

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Sep 29, 2020
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested with repro 1) create project/cluster/maintenance window in Atlas UI 2) import those to terraform with a provider built from this branch 3) do a terraform plan w/ tf that matches imported state. Now it shows no changes, as expected! Thank you!

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Sep 30, 2020
@coderGo93 coderGo93 requested a review from leofigy October 2, 2020 23:06
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Oct 2, 2020
@coderGo93 coderGo93 merged commit dfd7b22 into master Oct 3, 2020
@coderGo93 coderGo93 deleted the fix-289 branch October 3, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants