Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongo atlas client update fix #292 #312 #315

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Conversation

leofigy
Copy link
Contributor

@leofigy leofigy commented Sep 18, 2020

Description

Hi @themantissa , @coderGo93 , updating the library go-client-mongodb-atlas to
include the fix for the auth database field in the plugin

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Tested the username with spaces and the external db
local_test.log

@leofigy leofigy changed the title goclient update fix #292 #312 mongo atlas client update fix #292 #312 Sep 18, 2020
@leofigy leofigy requested a review from coderGo93 September 18, 2020 21:46
@leofigy leofigy self-assigned this Sep 18, 2020
@leofigy leofigy requested a review from themantissa September 18, 2020 21:58
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this updated from the latest changes from mongodb client master?, if so then LGTM!!

@leofigy
Copy link
Contributor Author

leofigy commented Sep 18, 2020

Hey @coderGo93 thanks, yes, it has the latest from main and the checks passed. :)

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! TY!

@leofigy leofigy merged commit c60cff3 into master Sep 18, 2020
@leofigy leofigy deleted the client-update-issue-292-312 branch September 22, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants