Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Moves bi_connector_config and advanced_configuration in TPF to blocks #2909

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

chore: Moves bi_connector_config and advanced_configuration in TPF to blocks #2909

wants to merge 13 commits into from

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Dec 18, 2024 •
edited
Loading

Description

Moves bi_connector_config and advanced_configuration in TPF to blocks

Link to any related issue(s): CLOUDP-290825

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli force-pushed the CLOUDP-290825_biconnector_advconfig branch from 7664ff4 to 8d70c4b Compare December 18, 2024 17:27
@lantoli lantoli marked this pull request as ready for review December 19, 2024 06:34
@lantoli lantoli requested a review from a team as a code owner December 19, 2024 06:34
EspenAlbert
EspenAlbert reviewed Dec 19, 2024
View reviewed changes
internal/common/conversion/admin_generation.go
"github.com/hashicorp/terraform-plugin-framework/types"
)

func SingleListTFToSDK[TFModel, SDKRequest any](ctx context.Context, diags *diag.Diagnostics, input *types.List, fnTransform func(tf TFModel) SDKRequest) SDKRequest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of Generic names!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed your lead :-)

EspenAlbert
EspenAlbert approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Did you do a manual check of the terraform import experience?

@lantoli
Copy link
Member Author

lantoli commented Dec 19, 2024 •
edited
Loading

Great! Did you do a manual check of the terraform import experience?

yes, commented offline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EspenAlbert EspenAlbert EspenAlbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lantoli @EspenAlbert