chore: Supports legacy API in create when using old schema with num_shards #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
reviewed
Dec 14, 2024
| @@ -190,7 +191,12 @@ func (r *rs) createCluster(ctx context.Context, plan *TFModel, diags *diag.Diagn | |||
| if pauseAfter { | |||
| latestReq.Paused = nil | |||
| } | |||
| _, _, err = api.CreateCluster(ctx, projectID, latestReq).Execute() | |||
| if usingLegacySchema(ctx, plan.ReplicationSpecs, diags) { | |||
There was a problem hiding this comment.
can we add an acc test that would fail before this change?
There was a problem hiding this comment.
See comment here: https://github.com/mongodb/terraform-provider-mongodbatlas/pull/2892/files#r1885034045
I don't know if we have any test that would have a failure by using this old API as I'm not 100% sure that it triggers ISS or auto_scaling_mode=SHARD 🤔
EspenAlbert
commented
Dec 14, 2024
| @@ -90,7 +90,7 @@ steps: | |||
| text: "true" | |||
| - path: /api/atlas/v2/groups/{groupId}/clusters | |||
| method: POST | |||
| version: '2024-10-23' | |||
| version: '2024-08-05' | |||
There was a problem hiding this comment.
@lantoli you can see the required update here
lantoli
added a commit
that referenced
this pull request
Dec 14, 2024
* master: chore: Supports legacy API in create when using old schema with num_shards (#2892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports legacy API in create when using old schema with num_shards
Link to any related issue(s): CLOUDP-287995
Type of change:
Required Checklist:
Further comments