-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds new advanced_configuration.0.default_max_time_ms
attribute to mongodbatlas_advanced_cluster
resource and data sources
#2825
Merged
+166
−35
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ead56a2
add default max time attr
maastha 224e10a
update test
maastha 78e7a5f
make optional
maastha 646dd78
minor
maastha f7d3100
migration
maastha 667b347
cleanup
maastha b4b44d7
add changelog
maastha 6ff282f
update readme
maastha 1be1aba
mdb version check
maastha 87ec371
fmt
maastha 21d9cf0
add validation
maastha 78c5b23
minor
maastha a3d6327
doc
maastha 51b9938
min
maastha 2586a98
minor
maastha a087f24
Merge branch 'master' into CLOUDP-250898-defaultreadmaxtimeMS
maastha 638c4bf
doc
maastha eb961e5
minor
maastha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
make optional
commit 78e7a5fd12fdeabc4e1a1f24b7c3c8c456f0d78c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return diag.FromErr(fmt.Errorf(errorConfigUpdate, cluster.GetName(), err)) | ||
} | ||
_, _, err = connV2.ClustersApi.UpdateClusterAdvancedConfiguration(ctx, projectID, cluster.GetName(), ¶ms).Execute() | ||
// log.Println(tmp) | ||
if err != nil { | ||
return diag.FromErr(fmt.Errorf(errorConfigUpdate, cluster.GetName(), err)) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with upstream this is expected to be user-managed, hence keeping optional