Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Marking online archive as preview feature for GCP #2802

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

cveticm
Copy link
Contributor

@cveticm cveticm commented Nov 14, 2024

Description

Noting within Online Archive resource doc that this feature is in Private Preview for Google Cloud Provider.

Link to any related issue(s): CLOUDP-280438

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@cveticm cveticm requested a review from a team as a code owner November 14, 2024 16:30
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

@@ -8,6 +8,8 @@

~> **IMPORTANT:** There are fields that are immutable after creation, i.e if `date_field` value does not exist in the collection, the online archive state will be pending forever, and this field cannot be updated, that means a destroy is required, known error `ONLINE_ARCHIVE_CANNOT_MODIFY_FIELD`

~> **IMPORTANT:** Support for Online Archive on `GCP` is available in Private Preview. To request access and participate in the Private Preview release of this feature, see the [registration sign-up](https://www.mongodb.com/products/platform/atlas-online-archive#promo).
Copy link
Collaborator

@EspenAlbert EspenAlbert Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, potentially I would remove release of this feature from:

To request access and participate in the Private Preview release of this feature

--> To request access and participate in the Private Preview, see the ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording was taken from here. I think its clearer to keep it as is as the alternative wording to me suggests all of private preview will be accessible.

Copy link
Contributor

@davidhou17 davidhou17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise LGTM

docs/resources/online_archive.md Outdated Show resolved Hide resolved
@cveticm cveticm merged commit 51a41d0 into master Nov 15, 2024
38 checks passed
@cveticm cveticm deleted the CLOUDP-280438 branch November 15, 2024 16:51
lantoli added a commit that referenced this pull request Nov 19, 2024
* master:
  chore: Adds Update Request Dumping for adv_cluster TPF (#2798)
  doc: Marking online archive as preview feature for GCP (#2802)
  chore: Removes mongoDBMajorVersion field from shared tier cluster tests (#2796)
  chore: Adds Create Request Dumping to advanced_cluster TPF (#2797)
  delay time decreased to 1 minute for create and delete in mongodbatlas_privatelink_endpoint_service (#2801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants