feat: Support pinned_fcv in attribute in cluster resource and data sources
#2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgustinBettati
force-pushed
the
CLOUDP-283841
branch
from
58f186e to
6d49ed9
Compare
AgustinBettati
commented
Nov 12, 2024
Comment on lines
-494
to
+518
| redactClientLogData, err := newAtlasGet(ctx, connV2, projectID, clusterName) | ||
| latestClusterModel, err := newAtlasGet(ctx, connV2, projectID, clusterName) | ||
| if err != nil { | ||
| return diag.FromErr(fmt.Errorf(errorClusterRead, clusterName, err)) | ||
| } | ||
| if err := d.Set("redact_client_log_data", redactClientLogData); err != nil { | ||
| if err := d.Set("redact_client_log_data", latestClusterModel.GetRedactClientLogData()); err != nil { | ||
| return diag.FromErr(fmt.Errorf(advancedcluster.ErrorClusterSetting, "redact_client_log_data", clusterName, err)) | ||
| } | ||
|
|
||
| if err := d.Set("pinned_fcv", advancedcluster.FlattenPinnedFCV(latestClusterModel)); err != nil { |
There was a problem hiding this comment.
as flatten function makes use of cluster SDK model, adjusted newAtlasGet to return the model directly
|
current failing tests in cluster group are not related and have been identified in nightly runs since Nov 9th:
|
AgustinBettati
commented
Nov 12, 2024
| "mongo_db_major_version": "7.0", | ||
| }), | ||
| }, | ||
| // TODO: add steps for upgrading and downgrading mongo_db_major_version |
There was a problem hiding this comment.
pending adjustment after upstream fix
|
This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to any related issue(s): CLOUDP-283841
NOTE - PR is currently in draft and cannot yet be merged: Waiting for a fix in 2024-10-23 cluster API to adjust response value of mongo_db_major_version property (CLOUDP-269950). This will enable users to upgrade and downgrade when having FCV pinned.
This PR uses #2789 as base branch, reusing
advanced_clusterFCV logic.Type of change:
Required Checklist:
Further comments