-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Supports running advanced_cluster_tpf
resource with tests in advancedcluster
package
#2786
test: Supports running advanced_cluster_tpf
resource with tests in advancedcluster
package
#2786
Conversation
internal/service/advancedcluster/resource_advanced_cluster_migration_test.go
Outdated
Show resolved
Hide resolved
internal/service/advancedcluster/resource_advanced_cluster_migration_test.go
Outdated
Show resolved
Hide resolved
internal/testutil/acc/pre_check.go
Outdated
tb.Helper() | ||
return func() { | ||
if os.Getenv("MONGODB_ATLAS_TPF_ADV_CLUSTER_TESTS") == "true" { | ||
tb.Skip("Skipping TPF Advanced Cluster tests") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: My understanding is not that we are skipping TPF advanced cluster tests but that we don't run tests on TPF advanced clusters at all. Is this a correct assumption? If so, I think a message more along the lines of "Skipping tests as resource is TPF Advanced Cluster" would make this more explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! Updated in 053deb3, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please Tag/DM if you want an update otherwise I might not see it 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like it! thanks for the follow-ups
Description
Supports running
advanced_cluster_tpf
resource with tests inadvancedcluster
package.Uses a new flag
MONGODB_ATLAS_TPF_ADV_CLUSTER_TESTS
to determine if we are in the tpf jobLink to any related issue(s): CLOUDP-283271
Type of change:
Required Checklist:
Further comments (screenshots of runs in a different testing repo)