Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve error message when networking peering reaches a failed status #2766

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

AgustinBettati
Copy link
Member

@AgustinBettati AgustinBettati commented Oct 31, 2024

Description

Link to any related issue(s): CLOUDP-268949

Reproduced a FAILED status by creating 2 network_peering resources with same azure account and cidr block range (using separate projects).

Before

mongodbatlas_network_peering.other: Still creating... [40s elapsed]
╷
│ Error: error creating MongoDB Network Peering Connection: unexpected state 'FAILED', wanted target 'AVAILABLE, PENDING_ACCEPTANCE'. last error: %!s(<nil>)
│ 
│   with mongodbatlas_network_peering.other,
│   on main.tf line 53, in resource "mongodbatlas_network_peering" "other":
│   53: resource "mongodbatlas_network_peering" "other" {
│ 

After

mongodbatlas_network_peering.other: Still creating... [40s elapsed]
╷
│ Error: Peer networking is in a failed state: Could not create peering connection in Atlas Azure account because a peer with an overlapping CIDR block already exists.
│ 
│   with mongodbatlas_network_peering.other,
│   on main.tf line 53, in resource "mongodbatlas_network_peering" "other":
│   53: resource "mongodbatlas_network_peering" "other" {
│ 

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@github-actions github-actions bot added the bug label Oct 31, 2024
@AgustinBettati AgustinBettati marked this pull request as ready for review November 4, 2024 10:43
@AgustinBettati AgustinBettati requested review from a team as code owners November 4, 2024 10:43
Copy link
Contributor

github-actions bot commented Nov 4, 2024

APIx bot: a message has been sent to Docs Slack channel

@AgustinBettati AgustinBettati merged commit bf6eb7a into master Nov 5, 2024
38 checks passed
@AgustinBettati AgustinBettati deleted the CLOUDP-268949-rebased branch November 5, 2024 13:47
svc-apix-Bot added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants