Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption at rest fix #27

Merged
merged 4 commits into from
Sep 13, 2019
Merged

Encryption at rest fix #27

merged 4 commits into from
Sep 13, 2019

Conversation

marinsalinas
Copy link
Contributor

No description provided.

@ghost ghost added the size/M label Sep 13, 2019
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 !

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for AWS minus one typo in error I've commented on. However we'll need the same update, I believe, for all 3 cloud providers. Edit: GCP, Azure will be corrected in separate PR.

encrypt, _, err := conn.EncryptionsAtRest.Get(context.Background(), projectID)

if err != nil {
return fmt.Errorf("error getting enctryption at rest information: %s", err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo = encryption.

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - appreciate the add of the website fix.

@marinsalinas marinsalinas merged commit bf08798 into master Sep 13, 2019
@marinsalinas marinsalinas deleted the encryption-at-rest-fix branch September 13, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants