-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encryption at rest fix #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for AWS minus one typo in error I've commented on. However we'll need the same update, I believe, for all 3 cloud providers. Edit: GCP, Azure will be corrected in separate PR.
encrypt, _, err := conn.EncryptionsAtRest.Get(context.Background(), projectID) | ||
|
||
if err != nil { | ||
return fmt.Errorf("error getting enctryption at rest information: %s", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo = encryption.
chore: change error comment
…ion in encryption_at_rest_resource
4bc1a89
to
0a682e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - appreciate the add of the website fix.
No description provided.