Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds docs for new attributes config_server_management_mode and config_server_type #2677

Conversation

EspenAlbert
Copy link
Collaborator

Description

chore: Adds docs for new attributes config_server_management_mode and config_server_type

Link to any related issue(s): CLOUDP-228611

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

Copy link
Contributor

@kyuan-mongodb kyuan-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % minor typo.

docs/data-sources/advanced_cluster.md Outdated Show resolved Hide resolved
docs/data-sources/advanced_clusters.md Outdated Show resolved Hide resolved
docs/resources/advanced_cluster.md Outdated Show resolved Hide resolved
@EspenAlbert EspenAlbert merged commit f690cfc into CLOUDP-228611_adv_cluster_sharded_embedded_config Oct 14, 2024
37 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-228611_adv_cluster_sharded_embedded_config_docs branch October 14, 2024 14:56
EspenAlbert added a commit that referenced this pull request Oct 14, 2024
…e` in advanced_cluster (#2670)

* feat: Supports `config_server_type` and `config_server_management_mode` in advanced_cluster

* test: Modifies test case for config_server_management_mode and config_server_type

* chore: add changelog entry

* fix: use config_server_management_mode and config_server_type in plural data source

* fix: supports updating both old cluster attributes and new attributes

* test: Use explicit depends_on to ensure reads happens after update

* refactor: simplify setter logic for new fields

* chore: Adds docs for new attributes `config_server_management_mode` and `config_server_type` (#2677)

* chore: add docs for `config_server_management_mode` and `config_server_type`

* Update docs/data-sources/advanced_cluster.md

Co-authored-by: kyuan-mongodb <[email protected]>

* Update docs/data-sources/advanced_clusters.md

Co-authored-by: kyuan-mongodb <[email protected]>

* Update docs/resources/advanced_cluster.md

Co-authored-by: kyuan-mongodb <[email protected]>

---------

Co-authored-by: kyuan-mongodb <[email protected]>

---------

Co-authored-by: kyuan-mongodb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants