-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds docs for new attributes config_server_management_mode
and config_server_type
#2677
Merged
EspenAlbert
merged 4 commits into
CLOUDP-228611_adv_cluster_sharded_embedded_config
from
CLOUDP-228611_adv_cluster_sharded_embedded_config_docs
Oct 14, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
13 tasks
APIx bot: a message has been sent to Docs Slack channel |
kyuan-mongodb
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % minor typo.
Co-authored-by: kyuan-mongodb <[email protected]>
Co-authored-by: kyuan-mongodb <[email protected]>
Co-authored-by: kyuan-mongodb <[email protected]>
EspenAlbert
merged commit Oct 14, 2024
f690cfc
into
CLOUDP-228611_adv_cluster_sharded_embedded_config
37 checks passed
EspenAlbert
deleted the
CLOUDP-228611_adv_cluster_sharded_embedded_config_docs
branch
October 14, 2024 14:56
EspenAlbert
added a commit
that referenced
this pull request
Oct 14, 2024
…e` in advanced_cluster (#2670) * feat: Supports `config_server_type` and `config_server_management_mode` in advanced_cluster * test: Modifies test case for config_server_management_mode and config_server_type * chore: add changelog entry * fix: use config_server_management_mode and config_server_type in plural data source * fix: supports updating both old cluster attributes and new attributes * test: Use explicit depends_on to ensure reads happens after update * refactor: simplify setter logic for new fields * chore: Adds docs for new attributes `config_server_management_mode` and `config_server_type` (#2677) * chore: add docs for `config_server_management_mode` and `config_server_type` * Update docs/data-sources/advanced_cluster.md Co-authored-by: kyuan-mongodb <[email protected]> * Update docs/data-sources/advanced_clusters.md Co-authored-by: kyuan-mongodb <[email protected]> * Update docs/resources/advanced_cluster.md Co-authored-by: kyuan-mongodb <[email protected]> --------- Co-authored-by: kyuan-mongodb <[email protected]> --------- Co-authored-by: kyuan-mongodb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chore: Adds docs for new attributes
config_server_management_mode
andconfig_server_type
Link to any related issue(s): CLOUDP-228611
Type of change:
Required Checklist:
Further comments