Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove versions from AWS OA DF PE example #2606

Conversation

nsmith78660
Copy link
Contributor

Description

Removing the versions from versions.tf for the privatelink example within the aws/oa_df directory. With the current versions it caused the following error:

╷
│ Error: Unsupported argument
│ 
│   on atlas-privatelink.tf line 12, in resource "mongodbatlas_privatelink_endpoint_service_data_federation_online_archive" "test":
│   12:   region                     = "US_EAST_1"
│ 
│ An argument named "region" is not expected here.
╵
╷
│ Error: Unsupported argument
│ 
│   on atlas-privatelink.tf line 13, in resource "mongodbatlas_privatelink_endpoint_service_data_federation_online_archive" "test":
│   13:   customer_endpoint_dns_name = aws_vpc_endpoint.vpce_east.dns_entry[0].dns_name
│ 
│ An argument named "customer_endpoint_dns_name" is not expected here.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Removing the versions from versions.tf to prevent possible customer errors
@nsmith78660 nsmith78660 requested a review from a team as a code owner September 17, 2024 20:36
Dialed in the version
@EspenAlbert
Copy link
Collaborator

Merged in #2614 thank you @nsmith78660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants