Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Backup Policy documentation #259

Merged
merged 4 commits into from
Jul 23, 2020
Merged

Updated Backup Policy documentation #259

merged 4 commits into from
Jul 23, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Jul 9, 2020

Description

Updated backup_policy documentation explaining how we can implement at least one policy item or remove ones.

Link to any related issue(s): #222

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helped me a great deal, as did running through the examples! I've included quite a bit here that I think will further clear this up. Let me know what you think.

@ghost ghost added size/L and removed size/S labels Jul 10, 2020
@PacoDw PacoDw requested a review from themantissa July 10, 2020 14:22
@PacoDw PacoDw force-pushed the policy-item-doc branch from f4e4b51 to d816cee Compare July 10, 2020 14:52
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples are good but some of the placement of the provided info is not in the best place. Let me know if this makes sense and I can perhaps submit a PR with the changes if that will help.
Just FYI - I don't want this to hold up 0.6.2 but also want to get better examples out - we may need to do 0.6.2 first and then do a special push for just this after.

@PacoDw PacoDw force-pushed the policy-item-doc branch from d816cee to 6db9067 Compare July 14, 2020 15:35
@PacoDw PacoDw requested a review from themantissa July 15, 2020 16:15
Modified PR branch to quicken pace of completion so we can proceed with repo move.
@themantissa
Copy link
Collaborator

@PacoDw this is a little non-standard but I made the changes I think we need in the last commit. Let me know if they make sense and then I can approve so we can move forward on closing these out. Thanks!

@PacoDw
Copy link
Contributor Author

PacoDw commented Jul 22, 2020

@themantissa no problem it's okay 👍

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (since made updates in last commit I think we still need). Let's wrap this up.

Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PacoDw PacoDw merged commit 49f5c35 into master Jul 23, 2020
@PacoDw PacoDw deleted the policy-item-doc branch July 23, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants