-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Backup Policy documentation #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helped me a great deal, as did running through the examples! I've included quite a bit here that I think will further clear this up. Let me know what you think.
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples are good but some of the placement of the provided info is not in the best place. Let me know if this makes sense and I can perhaps submit a PR with the changes if that will help.
Just FYI - I don't want this to hold up 0.6.2 but also want to get better examples out - we may need to do 0.6.2 first and then do a special push for just this after.
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_provider_snapshot_backup_policy.html.markdown
Outdated
Show resolved
Hide resolved
Modified PR branch to quicken pace of completion so we can proceed with repo move.
@PacoDw this is a little non-standard but I made the changes I think we need in the last commit. Let me know if they make sense and then I can approve so we can move forward on closing these out. Thanks! |
@themantissa no problem it's okay 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (since made updates in last commit I think we still need). Let's wrap this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updated backup_policy documentation explaining how we can implement at least one policy item or remove ones.
Link to any related issue(s): #222
Type of change:
Required Checklist:
Further comments