Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Uses PAT to be able to create PRs when versions of Terraform Compatibility Matrix change #2320

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Jun 3, 2024

Description

Uses PAT to be able to create PRs when versions of Terraform Compatibility Matrix change
Has run successfully and generated this PR: #2321
Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi marked this pull request as ready for review June 3, 2024 08:33
@oarbusi oarbusi requested a review from a team as a code owner June 3, 2024 08:33
@oarbusi oarbusi requested a review from a team as a code owner June 3, 2024 08:38
Copy link

@erabil-mdb erabil-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zuhairahmed
Copy link
Collaborator

@oarbusi this is awesome! do you know if this PAT will also be able to update documentation when new Terraform versions are added as well? for example Terraform v1.9 should be going GA over next few weeks https://github.com/hashicorp/terraform/releases

@oarbusi oarbusi merged commit c9865ba into master Jun 4, 2024
32 checks passed
@oarbusi oarbusi deleted the fix-create-pr-matrix branch June 4, 2024 07:55
@oarbusi
Copy link
Collaborator Author

oarbusi commented Jun 4, 2024

@oarbusi this is awesome! do you know if this PAT will also be able to update documentation when new Terraform versions are added as well? for example Terraform v1.9 should be going GA over next few weeks https://github.com/hashicorp/terraform/releases

@Zuhairahmed yes it will. In fact some months ago 1.8.x was added automatically #2137 . PAT was not needed before for that but now it is, that is why I created this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants