Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: importing a mongodbatlas_project_ip_whitelist resource does not save project_id to state #23

Merged
merged 1 commit into from
Sep 11, 2019
Merged

fix: importing a mongodbatlas_project_ip_whitelist resource does not save project_id to state #23

merged 1 commit into from
Sep 11, 2019

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Sep 11, 2019

closes #21

@ghost ghost added the size/XS label Sep 11, 2019
@PacoDw PacoDw mentioned this pull request Sep 11, 2019
Closed
@PacoDw
fix: add project_id value to the state
2ff562c 
chore: change error comment
themantissa
themantissa approved these changes Sep 11, 2019
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PacoDw PacoDw merged commit 7c141ce into master Sep 11, 2019
@PacoDw PacoDw deleted the fix-#21 branch September 11, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@marinsalinas marinsalinas marinsalinas approved these changes

@SpencerBrown SpencerBrown Awaiting requested review from SpencerBrown

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

importing a mongodbatlas_project_ip_whitelist resource does not save project_id to state
3 participants
@PacoDw @marinsalinas @themantissa