fix: Sets all attributes of Azure mongodbatlas_network_peering as ForceNew, forcing recreation of the resource when updating
#2299
Conversation
oarbusi
changed the title
network_peeringnetwork_peering
|
APIx bot: a message has been sent to Docs Slack channel |
oarbusi
changed the title
network_peeringmongodbatlas_network_peering
| @@ -64,6 +64,50 @@ func TestAccNetworkRSNetworkPeering_basicAzure(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccNetworkRSNetworkPeering_updateBasicAzure(t *testing.T) { | |||
| acc.SkipTestForCI(t) // needs Azure configuration | |||
There was a problem hiding this comment.
:( is it hard to have this information in our CI setup so that we can actually have it running?
There was a problem hiding this comment.
Main issue I found while running them locally is the limitation of network_container that in AWS and Azure there can only be one container per cloud provider region and that you can't delete a network peering container if your project contains clusters. I'll work around that so that we can have the tests run in the CI
There was a problem hiding this comment.
in case it can help, we improved cleanup process to delete endpoints: https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/scripts/cleanup-test-env.sh#L19
we could improve it to delete these projects as well if needed
There was a problem hiding this comment.
Done! Now the tests run in the CI
Co-authored-by: Agustin Bettati <[email protected]>
internal/service/networkpeering/resource_network_peering_test.go
Outdated
Show resolved
Hide resolved
|
After adding |
oarbusi
changed the title
mongodbatlas_network_peeringmongodbatlas_network_peering as ForceNew, forcing recreation of the resource when updating
Description
Sets all attributes when updating an Azure network peering resource.
Fixes #2281
Link to any related issue(s): CLOUDP-249269
Type of change:
Required Checklist:
Further comments