Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrates privatelink_endpoint_regional_mode to the new auto-generated SDK #2246

Merged

Conversation

EspenAlbert
Copy link
Collaborator

Description

Migratesprivatelink_endpoint_regional_modeto new auto-generated SDK

Link to any related issue(s): CLOUDP-246327

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert changed the title chore: Migratesprivatelink_endpoint_regional_mode to the new auto-generated SDK chore: Migrates privatelink_endpoint_regional_mode to the new auto-generated SDK May 7, 2024
@EspenAlbert EspenAlbert marked this pull request as ready for review May 7, 2024 14:13
@EspenAlbert EspenAlbert requested a review from a team as a code owner May 7, 2024 14:13
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once commented code is removed

@EspenAlbert EspenAlbert merged commit 99b6f89 into master May 8, 2024
32 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-246327_privatelink_endpoint_regional_mode branch May 8, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants