-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migratescloud_backup_snapshot_restore_job
to new auto-generated SDK
#2239
chore: Migratescloud_backup_snapshot_restore_job
to new auto-generated SDK
#2239
Conversation
cloud_backup_snapshot_restore_job
to new auto-generated SDKcloud_backup_snapshot_restore_job
to new auto-generated SDK
"oplog_ts": cloudProviderSnapshotRestoreJob.OplogTs, | ||
"point_in_time_utc_seconds": cloudProviderSnapshotRestoreJob.PointInTimeUTCSeconds, | ||
"oplog_inc": cloudProviderSnapshotRestoreJob.OplogInc, | ||
"id": cloudProviderSnapshotRestoreJob.GetId(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the getter methods here. As the legacy SDK doesn't use pointers, however, using time pointer conversion for the timestamps as the default timestamp value is probably unexpected.
Computed: true, | ||
Type: schema.TypeString, | ||
Computed: true, | ||
Deprecated: fmt.Sprintf(constant.DeprecationParamByVersion, "1.18.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created_at
:
- part of old v1 api
- removed in v2
…yload when it is empty
9481f2e
to
0b9678b
Compare
Description
Migrates
cloud_backup_snapshot_restore_job
to new auto-generated SDKLink to any related issue(s): CLOUDP-246319
Type of change:
Required Checklist:
Further comments