Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uses id as a computed attribute for data.cloud_backup_snapshot_export_job #2234

Merged

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented May 6, 2024

Description

Uses id as a computed attribute for the cloud_backup_snapshot_export_job data source

Refactors, the read for the resource and the data source to re-use the logic.
Fixes the acceptance test

Link to any related issue(s): CLOUDP-247721

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Acceptance test:
image

Migration test
image

@github-actions github-actions bot added the bug label May 6, 2024
@EspenAlbert EspenAlbert changed the title fix: Uses id as a computed attribute for cloud_backup_snapshot_export_job fix: Uses id as a computed attribute for data.cloud_backup_snapshot_export_job May 6, 2024
@EspenAlbert EspenAlbert marked this pull request as ready for review May 7, 2024 07:18
@EspenAlbert EspenAlbert requested review from a team as code owners May 7, 2024 07:18
Copy link
Contributor

github-actions bot commented May 7, 2024

APIx bot: a message has been sent to Docs Slack channel

Copy link
Contributor

@lmkerbey-mdb lmkerbey-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@EspenAlbert EspenAlbert merged commit afbd7b7 into master May 8, 2024
36 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-246318_cloud_backup_snapshot_export_job_fix branch May 8, 2024 05:29
svc-apix-Bot added a commit that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants