chore: Upgrades Atlas SDK to v20231115012 #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgustinBettati
commented
Apr 25, 2024
Comment on lines
-87
to
+90
| matchers[i] = map[string]any{ | ||
| "fieldName": matcher.FieldName.ValueString(), | ||
| "operator": matcher.Operator.ValueString(), | ||
| "value": matcher.Value.ValueString(), | ||
| matchers[i] = admin.StreamsMatcher{ | ||
| FieldName: matcher.FieldName.ValueString(), | ||
| Operator: matcher.Operator.ValueString(), | ||
| Value: matcher.Value.ValueString(), |
There was a problem hiding this comment.
Only change was in alert configuration matchers model which is now typed (was a map[string]any before).
AgustinBettati
commented
Apr 25, 2024
Comment on lines
-211
to
+205
| if !reflect.DeepEqual(resultModel, tc.expectedTFModel) { | ||
| t.Errorf("created terraform model did not match expected output.\n Expected: %s \n Result: %s", tc.expectedTFModel, resultModel) | ||
| } | ||
| assert.Equal(t, tc.expectedTFModel, resultModel, "created terraform model did not match expected output") |
There was a problem hiding this comment.
small pass by refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to any related issue(s): doing as part of CLOUDP-228077
This new SDK version includes the new
integrationIdproperty for alert configuration notifications.Type of change:
Required Checklist:
Further comments