Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Adjustments in online archive resource contemplating new support for azure provider #2194

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

AgustinBettati
Copy link
Member

@AgustinBettati AgustinBettati commented Apr 23, 2024

Description

Link to any related issue(s): CLOUDP-239897

As part of the ticket I verified that that azure provider can be used with the existing online_archive implementation. Adding small adjustment to documentation and an example.

There is already an existing acceptance test verifying the usage of data_process_region.cloud_provider and data_process_region.region so do not see a real need in adding a new one for azure.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@@ -96,13 +96,13 @@ resource "mongodbatlas_federated_database_instance" "test" {

* `project_id` - (Required) The unique ID for the project to create a Federated Database Instance.
* `name` - (Required) Name of the Atlas Federated Database Instance.
### `cloud_provider_config` - (Optional) Cloud provider linked to this data federated instance.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass by formatting fix in federated_database_instance docs

@AgustinBettati AgustinBettati marked this pull request as ready for review April 23, 2024 15:20
@AgustinBettati AgustinBettati requested a review from a team as a code owner April 23, 2024 15:20
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

@AgustinBettati AgustinBettati merged commit c3ace35 into master Apr 24, 2024
45 checks passed
@AgustinBettati AgustinBettati deleted the CLOUDP-239897-online-archive branch April 24, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants