chore: Restores notification when changelog update fails #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oarbusi
commented
Apr 19, 2024
| @@ -13,11 +13,48 @@ jobs: | |||
| with: | |||
| script_call: 'make tools update-changelog-unreleased-section' | |||
| file_to_commit: 'CHANGELOG.md' | |||
| commit_message: ${{ github.event_name == 'workflow_dispatch' && 'Update CHANGELOG.md (Manual Trigger)' || format('{0}{1}', 'Update CHANGELOG.md for \#', github.event.pull_request.number) }} | |||
| commit_message: ${{ github.event_name == 'workflow_dispatch' && format('{0}{1}', 'chore:',' Updates CHANGELOG.md (Manual Trigger)') || format('{0}{1}{2}{3}', 'chore:', ' Updates CHANGELOG.md for ', '#', github.event.pull_request.number) }} | |||
There was a problem hiding this comment.
":" and "#" are problematic in yaml files (reference), format method makes it work
There was a problem hiding this comment.
can't 'chore:' go in the same param as CHANGELO... ?
lantoli
reviewed
Apr 19, 2024
| }, | ||
| { | ||
| "type": "actions", |
There was a problem hiding this comment.
knit: consider use a link instead of an action, e.g. slack to docs
lantoli
approved these changes
Apr 19, 2024
AgustinBettati
approved these changes
Apr 19, 2024
| @@ -13,11 +13,48 @@ jobs: | |||
| with: | |||
| script_call: 'make tools update-changelog-unreleased-section' | |||
| file_to_commit: 'CHANGELOG.md' | |||
| commit_message: ${{ github.event_name == 'workflow_dispatch' && 'Update CHANGELOG.md (Manual Trigger)' || format('{0}{1}', 'Update CHANGELOG.md for \#', github.event.pull_request.number) }} | |||
| commit_message: ${{ github.event_name == 'workflow_dispatch' && format('{0}{1}', 'chore:',' Updates CHANGELOG.md (Manual Trigger)') || format('{0}{1}{2}{3}', 'chore:', ' Updates CHANGELOG.md for ', '#', github.event.pull_request.number) }} | |||
There was a problem hiding this comment.
can we adjust the commit message in the release process to include the chore prefix as well? All good if you prefer to handle in separate PR.
There was a problem hiding this comment.
I will include it in this PR. Thanks for the reminder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #2155 now that the automatic commit works
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments