-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removes ProjectIDGlobal #2173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
resource.ParallelTest(t, resource.TestCase{ | ||
// Serial so it doesn't conflict with TestAccNetworkContainer_basicAWS | ||
resource.Test(t, resource.TestCase{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this is not strictly related to this PR, but to fix potentially flaky from nightly run right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, it's more related to the PR this is following-up, i'll update the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Removes ProjectIDGlobal. Now that acc and mig test are run together, there is no benefit in having global projects for testing.
Fixes network flaky test that was introduce in folowed-up PR.
This PR is a follow-up for: #2156
Link to any related issue(s): CLOUDP-244186
Type of change:
Required Checklist:
Further comments