Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds support for Push-Based logging to S3 #2169

Merged
merged 17 commits into from
Apr 23, 2024
Merged

feat: Adds support for Push-Based logging to S3 #2169

merged 17 commits into from
Apr 23, 2024

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Apr 17, 2024 •
edited
Loading

Description

Adds resource and data source for Push-Based logging to S3

NOTE: Unit tests, Github workflow updates to run acceptance tests, examples & documentations will be done in separate PRs to keep the PRs small.

Link to any related issue(s):
CLOUDP-240969
CLOUDP-240970

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

image

@maastha maastha marked this pull request as ready for review April 18, 2024 08:48
@maastha maastha requested review from a team as code owners April 18, 2024 08:48
AgustinBettati
AgustinBettati reviewed Apr 18, 2024
View reviewed changes
.changelog/2169.txt Outdated Show resolved Hide resolved
.changelog/2169.txt Show resolved Hide resolved
internal/service/pushbasedlogexport/resource_schema.go Outdated Show resolved Hide resolved
internal/service/pushbasedlogexport/resource_schema.go Show resolved Hide resolved
JuliaMongo
JuliaMongo approved these changes Apr 18, 2024
View reviewed changes
Copy link

@JuliaMongo JuliaMongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for copy review with a few suggestions. Also tagging @zach-carr who might want to see this PR. Thank you!

.changelog/2169.txt Outdated Show resolved Hide resolved
.changelog/2169.txt Outdated Show resolved Hide resolved
internal/service/pushbasedlogexport/data_source_schema.go Outdated Show resolved Hide resolved
internal/service/pushbasedlogexport/data_source_schema.go Outdated Show resolved Hide resolved
internal/service/pushbasedlogexport/resource.go Outdated Show resolved Hide resolved
internal/service/pushbasedlogexport/resource_schema.go Outdated Show resolved Hide resolved
zach-carr
zach-carr approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@zach-carr zach-carr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maastha maastha changed the base branch from master to CLOUDP-244887-upgrade-atlas-sdk April 23, 2024 10:56
@maastha maastha changed the base branch from CLOUDP-244887-upgrade-atlas-sdk to master April 23, 2024 10:59
@maastha maastha marked this pull request as draft April 23, 2024 11:00
@maastha maastha changed the base branch from master to CLOUDP-244887-upgrade-atlas-sdk April 23, 2024 11:12
@maastha maastha changed the base branch from CLOUDP-244887-upgrade-atlas-sdk to master April 23, 2024 11:19
@maastha maastha marked this pull request as ready for review April 23, 2024 12:32
@github-actions GitHub Actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

lantoli
lantoli reviewed Apr 23, 2024
View reviewed changes
internal/service/pushbasedlogexport/data_source_schema.go
},
"create_date": schema.StringAttribute{
Computed: true,
Description: "Date and time that this feature was enabled on.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR, as we have the function to return the schema, we could have a helper function that for instance fill MarkdownDescription taking from Description if not filled so we only have one description in the code but it's filled for both Description and MarkdownDescription

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, adding @AgustinBettati for visibility. Right now I do see we have the same description in 4 places

lantoli
lantoli approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! and thanks for addressing the comments

@maastha maastha merged commit 3449f8b into master Apr 23, 2024
35 checks passed
@maastha maastha deleted the CLOUDP-240969-push-based-log-export branch April 23, 2024 13:48
svc-apix-Bot added a commit that referenced this pull request Apr 23, 2024
@svc-apix-Bot
chore: Updates CHANGELOG.md for #2169
76d37c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgustinBettati AgustinBettati AgustinBettati left review comments

@JuliaMongo JuliaMongo JuliaMongo approved these changes

@zach-carr zach-carr zach-carr approved these changes

@lantoli lantoli lantoli approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maastha @lantoli @AgustinBettati @zach-carr @JuliaMongo